Eranroz has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292041

Change subject: Fix Yoda-speak of TiteOptionWidget
......................................................................

Fix Yoda-speak of TiteOptionWidget

Adding auto dir for title suggestions.
* This should eliminate Yoda-speak (swaping words) as appear in T136641
* It should correctly align the title according to its (title infered) direction

This is works only in modern browsers supporting dir: auto

Bug: T136641
Change-Id: Iec0d3d27c0b51edfc0666f7fabac095a65e632e9
---
M resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
1 file changed, 1 insertion(+), 0 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/41/292041/1

diff --git a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js 
b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
index 84533aa..7e1baa9 100644
--- a/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
+++ b/resources/src/mediawiki.widgets/mw.widgets.TitleOptionWidget.js
@@ -49,6 +49,7 @@
 
                // Initialization
                this.$label.attr( 'href', config.url );
+               this.$label.attr( 'dir', 'auto' );
                this.$element.addClass( 'mw-widget-titleOptionWidget' );
 
                // Allow opening the link in new tab, but not regular 
navigation.

-- 
To view, visit https://gerrit.wikimedia.org/r/292041
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Iec0d3d27c0b51edfc0666f7fabac095a65e632e9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Eranroz <eranro...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to