Legoktm has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/292076

Change subject: SpecialMovepage: Use LinkRenderer instead of Linker::link()
......................................................................

SpecialMovepage: Use LinkRenderer instead of Linker::link()

Change-Id: I3b50354e62f47557a3a8ab1ec19a28f687887810
---
M includes/specials/SpecialMovepage.php
1 file changed, 17 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/292076/1

diff --git a/includes/specials/SpecialMovepage.php 
b/includes/specials/SpecialMovepage.php
index f49d730..72419a8 100644
--- a/includes/specials/SpecialMovepage.php
+++ b/includes/specials/SpecialMovepage.php
@@ -20,6 +20,8 @@
  * @file
  * @ingroup SpecialPage
  */
+use MediaWiki\Linker\LinkRenderer;
+use MediaWiki\MediaWikiServices;
 
 /**
  * A special page that allows users to change page titles
@@ -58,6 +60,11 @@
 
        private $watch = false;
 
+       /**
+        * @var LinkRenderer
+        */
+       private $linkRenderer;
+
        public function __construct() {
                parent::__construct( 'Movepage' );
        }
@@ -73,6 +80,7 @@
 
                $this->setHeaders();
                $this->outputHeader();
+               $this->linkRenderer = 
MediaWikiServices::getInstance()->getLinkRenderer();
 
                $request = $this->getRequest();
                $target = !is_null( $par ) ? $par : $request->getVal( 'target' 
);
@@ -601,13 +609,13 @@
                $out = $this->getOutput();
                $out->setPageTitle( $this->msg( 'pagemovedsub' ) );
 
-               $oldLink = Linker::link(
+               $oldLink = $this->linkRenderer->makeLink(
                        $ot,
                        null,
                        [ 'id' => 'movepage-oldlink' ],
                        [ 'redirect' => 'no' ]
                );
-               $newLink = Linker::linkKnown(
+               $newLink = $this->linkRenderer->makeKnownLink(
                        $nt,
                        null,
                        [ 'id' => 'movepage-newlink' ]
@@ -723,7 +731,7 @@
                        # be longer than 255 characters.
                        $newSubpage = Title::makeTitleSafe( $newNs, 
$newPageName );
                        if ( !$newSubpage ) {
-                               $oldLink = Linker::linkKnown( $oldSubpage );
+                               $oldLink = $this->linkRenderer->makeKnownLink( 
$oldSubpage );
                                $extraOutput[] = $this->msg( 
'movepage-page-unmoved' )->rawParams( $oldLink )
                                        ->params( Title::makeName( $newNs, 
$newPageName ) )->escaped();
                                continue;
@@ -731,7 +739,7 @@
 
                        # This was copy-pasted from Renameuser, bleh.
                        if ( $newSubpage->exists() && 
!$oldSubpage->isValidMoveTarget( $newSubpage ) ) {
-                               $link = Linker::linkKnown( $newSubpage );
+                               $link = $this->linkRenderer->makeKnownLink( 
$newSubpage );
                                $extraOutput[] = $this->msg( 
'movepage-page-exists' )->rawParams( $link )->escaped();
                        } else {
                                $success = $oldSubpage->moveTo( $newSubpage, 
true, $this->reason, $createRedirect );
@@ -740,14 +748,14 @@
                                        if ( $this->fixRedirects ) {
                                                
DoubleRedirectJob::fixRedirects( 'move', $oldSubpage, $newSubpage );
                                        }
-                                       $oldLink = Linker::link(
+                                       $oldLink = 
$this->linkRenderer->makeLink(
                                                $oldSubpage,
                                                null,
                                                [],
                                                [ 'redirect' => 'no' ]
                                        );
 
-                                       $newLink = Linker::linkKnown( 
$newSubpage );
+                                       $newLink = 
$this->linkRenderer->makeKnownLink( $newSubpage );
                                        $extraOutput[] = $this->msg( 
'movepage-page-moved' )
                                                ->rawParams( $oldLink, $newLink 
)->escaped();
                                        ++$count;
@@ -759,8 +767,8 @@
                                                break;
                                        }
                                } else {
-                                       $oldLink = Linker::linkKnown( 
$oldSubpage );
-                                       $newLink = Linker::link( $newSubpage );
+                                       $oldLink = 
$this->linkRenderer->makeKnownLink( $oldSubpage );
+                                       $newLink = 
$this->linkRenderer->makeLink( $newSubpage );
                                        $extraOutput[] = $this->msg( 
'movepage-page-unmoved' )
                                                ->rawParams( $oldLink, $newLink 
)->escaped();
                                }
@@ -805,7 +813,7 @@
                $out->addHTML( "<ul>\n" );
 
                foreach ( $subpages as $subpage ) {
-                       $link = Linker::link( $subpage );
+                       $link = $this->linkRenderer->makeLink( $subpage );
                        $out->addHTML( "<li>$link</li>\n" );
                }
                $out->addHTML( "</ul>\n" );

-- 
To view, visit https://gerrit.wikimedia.org/r/292076
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I3b50354e62f47557a3a8ab1ec19a28f687887810
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to