jenkins-bot has submitted this change and it was merged.
Change subject: Use tabs for indenting Gadget definition pages
......................................................................
Use tabs for indenting Gadget definition pages
For consistency with rest of MediaWiki, especially CodeEditor.
Note that this will cause dirty diffs for any definition pages created
before this patch, but that's not a big deal.
Change-Id: I3ed4b4aa7d18c489b9a322f67ea6ea31e610a257
---
M includes/content/GadgetDefinitionContent.php
M includes/content/GadgetDefinitionContentHandler.php
2 files changed, 2 insertions(+), 2 deletions(-)
Approvals:
Niharika29: Looks good to me, approved
Jdlrobson: Looks good to me, but someone else must approve
jenkins-bot: Verified
diff --git a/includes/content/GadgetDefinitionContent.php
b/includes/content/GadgetDefinitionContent.php
index c72d708..cc71d4a 100644
--- a/includes/content/GadgetDefinitionContent.php
+++ b/includes/content/GadgetDefinitionContent.php
@@ -40,7 +40,7 @@
*/
public function beautifyJSON() {
// @todo we should normalize entries in module.scripts and
module.styles
- return FormatJson::encode( $this->getAssocArray(), true,
FormatJson::UTF8_OK );
+ return FormatJson::encode( $this->getAssocArray(), "\t",
FormatJson::UTF8_OK );
}
/**
diff --git a/includes/content/GadgetDefinitionContentHandler.php
b/includes/content/GadgetDefinitionContentHandler.php
index 49d4f18..7bee7f4 100644
--- a/includes/content/GadgetDefinitionContentHandler.php
+++ b/includes/content/GadgetDefinitionContentHandler.php
@@ -39,7 +39,7 @@
public function makeEmptyContent() {
$class = $this->getContentClass();
- return new $class( FormatJson::encode(
$this->getDefaultMetadata(), true ) );
+ return new $class( FormatJson::encode(
$this->getDefaultMetadata(), "\t" ) );
}
public function getDefaultMetadata() {
--
To view, visit https://gerrit.wikimedia.org/r/271025
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I3ed4b4aa7d18c489b9a322f67ea6ea31e610a257
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Gadgets
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Fhocutt <fhoc...@wikimedia.org>
Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org>
Gerrit-Reviewer: Kaldari <rkald...@wikimedia.org>
Gerrit-Reviewer: Niharika29 <nihar...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
