Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/292185
Change subject: Simplify teardown of toolbar save button
......................................................................
Simplify teardown of toolbar save button
Bug: T136421
Change-Id: I6829ad75b93c6aa6c6db51b5c9cd84915c75cdb8
(cherry picked from commit 0a0ca68d62a4d8816103d080253e1648ea227c55)
---
M modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
1 file changed, 1 insertion(+), 6 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/85/292185/1
diff --git a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
index 192820a..d0beb44 100644
--- a/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
+++ b/modules/ve-mw/init/targets/ve.init.mw.DesktopArticleTarget.js
@@ -609,12 +609,7 @@
this.originalEditondbclick = undefined;
if ( this.toolbarSaveButton ) {
- // If deactivate is called before a successful load, then the
save button has not yet been
- // fully set up so disconnecting it would throw an error when
trying call methods on the
- // button property (bug 46456)
- this.toolbarSaveButton.disconnect( this );
- this.toolbarSaveButton.$element.detach();
- this.getToolbar().$actions.empty();
+ this.toolbarSaveButton = null;
}
// Check we got as far as setting up the surface
--
To view, visit https://gerrit.wikimedia.org/r/292185
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6829ad75b93c6aa6c6db51b5c9cd84915c75cdb8
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: wmf/1.28.0-wmf.4
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
Gerrit-Reviewer: Esanders <esand...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
