Nikerabbit has uploaded a new change for review. https://gerrit.wikimedia.org/r/292349
Change subject: Remove too generic tail class from message group selector ...................................................................... Remove too generic tail class from message group selector It isn't really needed. $trigger.nextAll().remove() does everything we need. This also removes two global dom queries and fixes a fixme while doing that. Change-Id: Ib8a5176efd7a4511e6bc6a792ff0ce034c07311d --- M resources/js/ext.translate.groupselector.js M specials/SpecialTranslate.php 2 files changed, 4 insertions(+), 9 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Translate refs/changes/49/292349/1 diff --git a/resources/js/ext.translate.groupselector.js b/resources/js/ext.translate.groupselector.js index eb0bb80..b6843db 100644 --- a/resources/js/ext.translate.groupselector.js +++ b/resources/js/ext.translate.groupselector.js @@ -188,19 +188,14 @@ groupSelector.hide(); groupSelector.$trigger - .removeClass( 'tail' ) + .addClass( 'expanded' ) .nextAll().remove(); - - groupSelector.$trigger.addClass( 'expanded' ); - // FIXME In future, if we are going to have multiple groupselectors per page - // this will fail. - $( '.tux-breadcrumb .tail' ).remove(); if ( !groupSelector.options.preventSelector ) { $newLink = $( '<span>' ) - .addClass( 'grouptitle grouplink tail' ) + .addClass( 'grouptitle grouplink' ) .text( messageGroup.label ); - $( '.tux-breadcrumb .grouplink:last' ).after( $newLink ); + groupSelector.$trigger.after( $newLink ); $newLink.data( 'msggroupid', messageGroup.id ); if ( messageGroup.groups && messageGroup.groups.length > 0 ) { diff --git a/specials/SpecialTranslate.php b/specials/SpecialTranslate.php index 8212670..15f1c84 100644 --- a/specials/SpecialTranslate.php +++ b/specials/SpecialTranslate.php @@ -590,7 +590,7 @@ ) . Html::element( 'span', array( - 'class' => 'grouptitle grouplink tail', + 'class' => 'grouptitle grouplink', 'data-msggroupid' => $this->options['group'], ), $group->getLabel() -- To view, visit https://gerrit.wikimedia.org/r/292349 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: Ib8a5176efd7a4511e6bc6a792ff0ce034c07311d Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Translate Gerrit-Branch: master Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits