jenkins-bot has submitted this change and it was merged. Change subject: demos: Add descriptive hints on navigation types to dialog names ......................................................................
demos: Add descriptive hints on navigation types to dialog names Adding descriptive hints what special navigation is to expect at certain dialog. Also fixing small difference in “Indexed dialog”. Change-Id: I802c2d62ed86faf93a14e8ae1aa26beb923eba38 --- M demos/pages/dialogs.js 1 file changed, 4 insertions(+), 4 deletions(-) Approvals: Bartosz Dziewoński: Looks good to me, approved jenkins-bot: Verified diff --git a/demos/pages/dialogs.js b/demos/pages/dialogs.js index 8085dd3..a6b6032 100644 --- a/demos/pages/dialogs.js +++ b/demos/pages/dialogs.js @@ -434,7 +434,7 @@ IndexedDialog.parent.call( this, config ); } OO.inheritClass( IndexedDialog, OO.ui.ProcessDialog ); - IndexedDialog.static.title = 'Index dialog'; + IndexedDialog.static.title = 'Indexed dialog'; IndexedDialog.static.actions = [ { action: 'save', label: 'Done', flags: [ 'primary', 'progressive' ] }, { action: 'cancel', label: 'Cancel', flags: 'safe' } @@ -789,21 +789,21 @@ } }, { - name: 'Outlined booklet dialog', + name: 'Outlined booklet dialog (aside navigation)', dialogClass: OutlinedBookletDialog, config: { size: 'medium' } }, { - name: 'Continuous outlined booklet dialog', + name: 'Continuous outlined booklet dialog (aside navigation)', dialogClass: ContinuousOutlinedBookletDialog, config: { size: 'medium' } }, { - name: 'Indexed dialog', + name: 'Indexed dialog (tab navigation)', dialogClass: IndexedDialog, config: { size: 'medium' -- To view, visit https://gerrit.wikimedia.org/r/292764 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I802c2d62ed86faf93a14e8ae1aa26beb923eba38 Gerrit-PatchSet: 3 Gerrit-Project: oojs/ui Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: Bartosz Dziewoński <matma....@gmail.com> Gerrit-Reviewer: Jforrester <jforres...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits