jenkins-bot has submitted this change and it was merged.

Change subject: Remove references section after removing blacklisted references
......................................................................


Remove references section after removing blacklisted references

Bug: T135037
Change-Id: Icd5266574b147b6c64463cbc00549564e5da4ebe
---
M includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
1 file changed, 7 insertions(+), 5 deletions(-)

Approvals:
  Hoo man: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua 
b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
index 6bba8ae..62d59ca 100644
--- a/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
+++ b/includes/Lua/mw.ext.articlePlaceholder.entityRenderer.lua
@@ -87,13 +87,15 @@
     references = removeBlacklistedReferences( references )
   end
 
-  if references ~= nil then
+  local i, reference = next( references, nil )
+
+  if i then
     hasReferences = true
-    local i = 1
-    while references[i] do
-      referenceWikitext = snaksRenderer( references[i]['snaks'] )
+
+    while i do
+      referenceWikitext = snaksRenderer( reference['snaks'] )
       table.insert( referencesWikitext, frame:extensionTag( 'ref', 
referenceWikitext ) )
-      i = i + 1
+      i, reference = next( references, i )
     end
   end
 

-- 
To view, visit https://gerrit.wikimedia.org/r/290463
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Icd5266574b147b6c64463cbc00549564e5da4ebe
Gerrit-PatchSet: 6
Gerrit-Project: mediawiki/extensions/ArticlePlaceholder
Gerrit-Branch: master
Gerrit-Owner: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Hoo man <[email protected]>
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Lucie Kaffee <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to