Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293118
Change subject: build: Bump devDependencies to latest and make pass
......................................................................
build: Bump devDependencies to latest and make pass
babel-polyfill 6.8.0 → 6.9.1
grunt-jscs 2.8.0 → 3.0.0
grunt-jsonlint 1.0.7 → 1.0.8
grunt-stylelint 0.3.0 → 0.4.0
stylelint-config-wikimedia 0.2.0 → 0.2.2
Change-Id: I4db467c7f2bc291a94e7bab86d18e48a44f6054c
---
M .jscsrc
M modules/ve-mw/init/classListSkipFunction.js
M modules/ve-mw/init/ve.init.mw.ArticleTarget.js
M modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
M modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
M package.json
6 files changed, 22 insertions(+), 18 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/18/293118/1
diff --git a/.jscsrc b/.jscsrc
index 023541b..6473d3f 100644
--- a/.jscsrc
+++ b/.jscsrc
@@ -17,5 +17,9 @@
"requireNewlineAfterDescription": true,
"requireParamTypes": true,
"requireReturnTypes": true
- }
+ },
+
+ "excludeFiles": [
+ "modules/ve-mw/init/classListSkipFunction.js"
+ ]
}
diff --git a/modules/ve-mw/init/classListSkipFunction.js
b/modules/ve-mw/init/classListSkipFunction.js
index 4be1da4..bb0c46f 100644
--- a/modules/ve-mw/init/classListSkipFunction.js
+++ b/modules/ve-mw/init/classListSkipFunction.js
@@ -6,9 +6,9 @@
* Adapted from
http://purl.eligrey.com/github/classList.js/blob/master/classList.js
*/
return !!(
- 'classList' in document.createElement( '_' ) &&
- !(
- document.createElementNS &&
- !( 'classList' in document.createElementNS(
'http://www.w3.org/2000/svg', 'g' ) )
- )
- );
+ 'classList' in document.createElement( '_' ) &&
+ !(
+ document.createElementNS &&
+ !( 'classList' in document.createElementNS(
'http://www.w3.org/2000/svg', 'g' ) )
+ )
+);
diff --git a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
index 4cc8e45..56b1fbf 100644
--- a/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
+++ b/modules/ve-mw/init/ve.init.mw.ArticleTarget.js
@@ -1724,9 +1724,9 @@
if ( prefSaysShow ) {
new mw.Api().saveOption(
'visualeditor-hidebetawelcome', '1' );
- // No need to set a cookie every time for logged-in users that
have already
- // set the hidebetawelcome=1 preference, but only if this isn't
a one-off
- // view of the page via the hiding GET parameter.
+ // No need to set a cookie every time for logged-in
users that have already
+ // set the hidebetawelcome=1 preference, but only if
this isn't a one-off
+ // view of the page via the hiding GET parameter.
} else if ( !usePrefs && !urlSaysHide ) {
try {
localStorage.setItem( 've-beta-welcome-dialog',
1 );
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
index fc62d5f..5889b78 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWAceEditorWidget.js
@@ -117,7 +117,7 @@
*
* @param {string} mode Symbolic name of autocomplete mode
*/
- ve.ui.MWAceEditorWidget.prototype.setAutocomplete = function ( mode ) {
+ve.ui.MWAceEditorWidget.prototype.setAutocomplete = function ( mode ) {
var widget = this;
this.autocomplete = mode;
this.loadingPromise.done( function () {
@@ -127,7 +127,7 @@
} );
} );
return this;
- };
+};
/**
* @inheritdoc
diff --git a/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
b/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
index 9c230a5..aa23472 100644
--- a/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
+++ b/modules/ve-mw/ui/widgets/ve.ui.MWTocWidget.js
@@ -84,7 +84,7 @@
*
* @param {ve.dm.MetaItem} metaItem
*/
- ve.ui.MWTocWidget.prototype.onMetaListInsert = function ( metaItem ) {
+ve.ui.MWTocWidget.prototype.onMetaListInsert = function ( metaItem ) {
// Responsible for adding UI components
if ( metaItem instanceof ve.dm.MWTOCForceMetaItem ) {
// show
diff --git a/package.json b/package.json
index 163fbd8..e0d528e 100644
--- a/package.json
+++ b/package.json
@@ -9,16 +9,16 @@
"postdoc": "grunt copy:jsduck"
},
"devDependencies": {
- "babel-polyfill": "6.8.0",
+ "babel-polyfill": "6.9.1",
"grunt": "1.0.1",
"grunt-banana-checker": "0.5.0",
"grunt-contrib-copy": "1.0.0",
"grunt-contrib-jshint": "1.0.0",
"grunt-contrib-watch": "1.0.0",
- "grunt-jscs": "2.8.0",
- "grunt-jsonlint": "1.0.7",
- "grunt-stylelint": "0.3.0",
+ "grunt-jscs": "3.0.0",
+ "grunt-jsonlint": "1.0.8",
+ "grunt-stylelint": "0.4.0",
"grunt-tyops": "0.1.0",
- "stylelint-config-wikimedia": "0.2.0"
+ "stylelint-config-wikimedia": "0.2.2"
}
}
--
To view, visit https://gerrit.wikimedia.org/r/293118
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I4db467c7f2bc291a94e7bab86d18e48a44f6054c
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
