Glaisher has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293133
Change subject: Remove email confirmation from Special:TranslatorSignup
......................................................................
Remove email confirmation from Special:TranslatorSignup
Instead of trying to implement this ourselves (which we cannot
guarantee to work as expected always), link to the standard
Special:ConfirmEmail page. This button currently doesn't even
show any feedback to the user.
Change-Id: I59e4e16ed6886fba9b2b5f1e3d8ceedbd4c6ebbd
---
M SpecialTranslatorSignup.php
M i18n/qqq.json
2 files changed, 6 insertions(+), 11 deletions(-)
git pull
ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/TranslationNotifications
refs/changes/33/293133/1
diff --git a/SpecialTranslatorSignup.php b/SpecialTranslatorSignup.php
index eaf9601..2be9876 100644
--- a/SpecialTranslatorSignup.php
+++ b/SpecialTranslatorSignup.php
@@ -81,12 +81,13 @@
$status = $this->msg(
'translationnotifications-email-confirmed' )->parse();
}
} elseif ( trim( $user->getEmail() ) !== '' ) {
- $submit = Xml::submitButton(
- $this->msg( 'confirmemail_send' )->text(),
- [ 'name' => 'x' ]
+ $confirmMail = Linker::linkKnown(
+ SpecialPage::getTitleFor( 'Confirmemail' ),
+ $this->msg( 'emailconfirmlink' )->escaped()
);
$status = $this->msg(
'translationnotifications-email-unconfirmed' )
- ->rawParams( $submit )->parse();
+ ->rawParams( $confirmMail )->parse();
+
} else {
$status = $this->msg(
'translationnotifications-email-notset' )->parse();
}
@@ -182,12 +183,6 @@
*/
public function onSubmit( array $formData ) {
$user = $this->getUser();
-
- if ( $this->getRequest()->getVal( 'x' ) === $this->msg(
'confirmemail_send' )->text() ) {
- // @todo Show message to user.
- $user->sendConfirmationMail( 'set' );
- return;
- }
foreach ( $formData as $key => $value ) {
$user->setOption( "translationnotifications-$key",
$value );
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 7662728..1966496 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -21,7 +21,7 @@
"translationnotifications-emailstatus": "Label",
"translationnotifications-email-confirmed": "Status of email
confirmation after {{msg-mw|translationnotifications-emailstatus}}.",
"translationnotifications-email-disablemail": "A message that appears
on top of Special:TranslatorSignup if the email address is confirmed, the user
disabled email in the preferences.",
- "translationnotifications-email-unconfirmed": "Status of email
confirmation after
{{msg-mw|Translationnotifications-emailstatus}}.\n\nParameters:\n* $1 - a
button which can be used to send confirmation email. Button text is
{{msg-mw|Confirmemail send}}.",
+ "translationnotifications-email-unconfirmed": "Status of email
confirmation after
{{msg-mw|Translationnotifications-emailstatus}}.\n\nParameters:\n* $1 - link to
Special:Confirmemail. Label of the link is {{msg-mw|emailconfirmlink}}.",
"translationnotifications-email-notset": "Status of email confirmation
after {{msg-mw|translationnotifications-emailstatus}}.",
"translationnotifications-languages": "Fieldset
header.\n{{Identical|Language}}",
"translationnotifications-lang": "Label for select. Parameters:\n* $1 -
a number\n{{Identical|Language}}",
--
To view, visit https://gerrit.wikimedia.org/r/293133
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I59e4e16ed6886fba9b2b5f1e3d8ceedbd4c6ebbd
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/TranslationNotifications
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
