Ejegg has uploaded a new change for review.
https://gerrit.wikimedia.org/r/293147
Change subject: Log an error when banner translation retrieval fails
......................................................................
Log an error when banner translation retrieval fails
We saw this with B1516_0607_heIL_dsk_p2_sm_pym_adyen in the 6/7 test.
BannerLoader sent back some js with
"bannerHtml":"<B1516_0607_heIL_dsk_p2_sm_pym_adyen>"
Making a dummy edit to the banner and re-saving cleared up the problem,
but there's still way less traffic than expected.
Change-Id: I6dc8c540e07db225183645a12a097ae3c19793e7
---
M includes/BannerRenderer.php
1 file changed, 8 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/CentralNotice
refs/changes/47/293147/1
diff --git a/includes/BannerRenderer.php b/includes/BannerRenderer.php
index 4b77a60..08a7c33 100644
--- a/includes/BannerRenderer.php
+++ b/includes/BannerRenderer.php
@@ -131,7 +131,14 @@
$parentLang = $lang->getParentLanguage();
}
- $bannerHtml = $this->context->msg( $this->banner->getDbKey()
)->inLanguage( $parentLang )->text();
+ $bannerKey = $this->banner->getDbKey();
+ $bannerHtml = $this->context->msg( $bannerKey )->inLanguage(
$parentLang )->text();
+ if ( $bannerHtml === "<$bannerKey>" ) {
+ // Translation subsystem failure
+ throw new RuntimeException(
+ "Banner message key $bannerKey could not be
found in {$parentLang->getCode()}"
+ );
+ }
$bannerHtml .= $this->getResourceLoaderHtml();
$bannerHtml = $this->substituteMagicWords( $bannerHtml );
--
To view, visit https://gerrit.wikimedia.org/r/293147
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6dc8c540e07db225183645a12a097ae3c19793e7
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ejegg <eeggles...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
