Chad has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/293751

Change subject: Remove useless sort parameter to printArray()
......................................................................

Remove useless sort parameter to printArray()

All callers use the default

Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e
---
M maintenance/findHooks.php
1 file changed, 2 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/51/293751/1

diff --git a/maintenance/findHooks.php b/maintenance/findHooks.php
index d44581c..1dcbe9f 100644
--- a/maintenance/findHooks.php
+++ b/maintenance/findHooks.php
@@ -328,12 +328,11 @@
        }
 
        /**
-        * Nicely output the array
+        * Nicely sort an print an array
         * @param string $msg A message to show before the value
         * @param array $arr
-        * @param bool $sort Whether to sort the array (Default: true)
         */
-       private function printArray( $msg, $arr, $sort = true ) {
+       private function printArray( $msg, $arr ) {
                if ( $sort ) {
                        asort( $arr );
                }

-- 
To view, visit https://gerrit.wikimedia.org/r/293751
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: If2a5cd64242f3b3d9ad9a99f5af7fb5b93438e8e
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Chad <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to