Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294259
Change subject: PHPVersionCheck: Require curl to be installed
......................................................................
PHPVersionCheck: Require curl to be installed
The cURL PHP extension is needed once you use any new feature that
makes HTTP calls. Although a few older paths provide a fallback by
using file streams, this isn't practical for MultiHTTPClient which
is used for amongst other important features VisualEditor (via the
VirtualRESTServiceClient). Failure to have cURL installed is a big
cause of third party user confusion, and the installer already for
some time has suggested that they install it. Instead of
[TODO:
* Add something to the release notes once Chad decides if this is
going into 1.27 or 1.28.
* Remove i18n string config-install-subscribe-notpossible about a
now-impossible situation.
* Remove fallback code in HttpFunctions now that's no longer
needed, and possibly simplify.
* Think about switching use over to curl in SquidPurgeClient.
* Remove pre-PHP5.5 conditionals from MultiHTTPClient.]
Change-Id: I08e5748d845040bf4e05ae29f68a867239a2f119
---
M includes/PHPVersionCheck.php
1 file changed, 3 insertions(+), 0 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/59/294259/1
diff --git a/includes/PHPVersionCheck.php b/includes/PHPVersionCheck.php
index 64a3e45..a9fcd10 100644
--- a/includes/PHPVersionCheck.php
+++ b/includes/PHPVersionCheck.php
@@ -61,6 +61,9 @@
if ( !function_exists( 'iconv' ) ) {
wfMissingExtension( $entryPoint, $mwVersion, 'iconv' );
}
+ if ( !function_exists( 'curl_multi_exec' ) ) {
+ wfMissingExtension( $entryPoint, $mwVersion, 'curl' );
+ }
}
/**
--
To view, visit https://gerrit.wikimedia.org/r/294259
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I08e5748d845040bf4e05ae29f68a867239a2f119
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
