Alex Monk has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294359
Change subject: Hack to not show menu immediately upon meta dialog opening for
redirect change
......................................................................
Hack to not show menu immediately upon meta dialog opening for redirect change
Bug: T137309
Change-Id: Iba22b909e8208d2a314de8313db9d910410c9a1d
---
M modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
1 file changed, 12 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/59/294359/1
diff --git a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
index 3ffaa92..6ada176 100644
--- a/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
+++ b/modules/ve-mw/ui/pages/ve.ui.MWSettingsPage.js
@@ -195,10 +195,21 @@
* @param {boolean} value Whether a redirect is to be set for this page
*/
ve.ui.MWSettingsPage.prototype.onEnableRedirectChange = function ( value ) {
+ var page = this;
this.redirectTargetInput.setDisabled( !value );
this.enableStaticRedirectInput.setDisabled( !value );
if ( value ) {
- this.redirectTargetInput.focus();
+ /*
+ * HACK: Using setTimeout because we need to defer this until
after
+ * the dialog has opened - otherwise it's internal
lookupDisabled
+ * logic will fail to have any effect during the actual focusing
+ * and calling of OO.ui.LookupElement#onLookupInputFocus/
+ * OO.ui.LookupElement#populateLookupMenu.
+ * https://phabricator.wikimedia.org/T137309
+ */
+ setTimeout( function () {
+ page.redirectTargetInput.focus();
+ }, 0 );
} else {
this.redirectTargetInput.setValue( '' );
this.enableStaticRedirectInput.setSelected( false );
--
To view, visit https://gerrit.wikimedia.org/r/294359
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iba22b909e8208d2a314de8313db9d910410c9a1d
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Alex Monk <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
