BBlack has uploaded a new change for review.
https://gerrit.wikimedia.org/r/294371
Change subject: un-anchor regexes for select
......................................................................
un-anchor regexes for select
We already have warnings and pre-notification of intended changes
to prevent accidents. Forcing regexes to be anchored is a pain,
especially on hostnames when doing operations on multiple hosts.
---
M conftool/cli/tool.py
1 file changed, 1 insertion(+), 2 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/software/conftool
refs/changes/71/294371/1
diff --git a/conftool/cli/tool.py b/conftool/cli/tool.py
index fff8e20..675547d 100644
--- a/conftool/cli/tool.py
+++ b/conftool/cli/tool.py
@@ -160,8 +160,7 @@
def parse_selectors(self):
for tag in self.args.selector.split(','):
k, expr = tag.split('=', 1)
- # All our selector are anchored regexes
- self.selectors[k] = re.compile('^%s$' % expr)
+ self.selectors[k] = re.compile(expr)
def host_list(self):
"""Gets all the hosts matching our selectors"""
--
To view, visit https://gerrit.wikimedia.org/r/294371
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ieef5448f516b9ef549fe9b9caa59ebbca0970b5e
Gerrit-PatchSet: 1
Gerrit-Project: operations/software/conftool
Gerrit-Branch: master
Gerrit-Owner: BBlack <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
