jenkins-bot has submitted this change and it was merged. Change subject: Pass empty summary to parseAndStash() to avoid warnings ......................................................................
Pass empty summary to parseAndStash() to avoid warnings Since the summary is not known yet, using "" is fine. Bug: T137995 Change-Id: I0ef2a6cbe3ffc9be249bfea5e4172159c57698a2 --- M ApiVisualEditor.php 1 file changed, 1 insertion(+), 1 deletion(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified diff --git a/ApiVisualEditor.php b/ApiVisualEditor.php index 5676b26..c5c863f 100644 --- a/ApiVisualEditor.php +++ b/ApiVisualEditor.php @@ -140,7 +140,7 @@ $page = WikiPage::factory( $title ); $content = ContentHandler::makeContent( $text, $title, CONTENT_MODEL_WIKITEXT ); - $status = ApiStashEdit::parseAndStash( $page, $content, $this->getUser() ); + $status = ApiStashEdit::parseAndStash( $page, $content, $this->getUser(), '' ); if ( $status === ApiStashEdit::ERROR_NONE ) { wfDebugLog( 'StashEdit', "Cached parser output for VE content key '$key'." ); } -- To view, visit https://gerrit.wikimedia.org/r/294833 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I0ef2a6cbe3ffc9be249bfea5e4172159c57698a2 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/VisualEditor Gerrit-Branch: wmf/1.28.0-wmf.6 Gerrit-Owner: Hashar <has...@free.fr> Gerrit-Reviewer: Aaron Schulz <asch...@wikimedia.org> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits