Jhobs has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295012
Change subject: Enable wikibase descriptions for beta, even if disabled for
production
......................................................................
Enable wikibase descriptions for beta, even if disabled for production
* To be removed upon enabling in production
* Also fix a minor hygiene problem
Bug: T127250
Change-Id: Ic6324788c6e04eeb9b65d63eff042d7755f759d9
---
M includes/MobileFrontend.hooks.php
M includes/skins/SkinMinerva.php
2 files changed, 4 insertions(+), 3 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MobileFrontend
refs/changes/12/295012/1
diff --git a/includes/MobileFrontend.hooks.php
b/includes/MobileFrontend.hooks.php
index 9c1b09c..8883d52 100644
--- a/includes/MobileFrontend.hooks.php
+++ b/includes/MobileFrontend.hooks.php
@@ -1266,7 +1266,8 @@
$outputPage->enableTOC( false );
$outputPage->setProperty( 'MFTOC', $po->getTOCHTML()
!== '' );
- if ( $mfUseWikibaseDescription ) {
+ // FIXME: Remove beta check once enabled in production
+ if ( $mfUseWikibaseDescription ||
$context->isBetaGroupMember() ) {
$item = $po->getProperty( 'wikibase_item' );
if ( $item ) {
$desc =
ExtMobileFrontend::getWikibaseDescription( $item );
diff --git a/includes/skins/SkinMinerva.php b/includes/skins/SkinMinerva.php
index 1e2e044..3c6ed58 100644
--- a/includes/skins/SkinMinerva.php
+++ b/includes/skins/SkinMinerva.php
@@ -957,8 +957,8 @@
$vars = [
'wgMinervaMenuData' => $this->getMenuData(),
// Expose for skins.minerva.tablet.scripts
- 'wgMinervaTocEnabled' =>
$this->getOutput()->getProperty( 'MFTOC' ),
- 'wgMFDescription' => $this->getOutput()->getProperty(
'wgMFDescription' ),
+ 'wgMinervaTocEnabled' => $out->getProperty( 'MFTOC' ),
+ 'wgMFDescription' => $out->getProperty(
'wgMFDescription' ),
];
if ( $this->isAuthenticatedUser() ) {
--
To view, visit https://gerrit.wikimedia.org/r/295012
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic6324788c6e04eeb9b65d63eff042d7755f759d9
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MobileFrontend
Gerrit-Branch: master
Gerrit-Owner: Jhobs <jhob...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
