jenkins-bot has submitted this change and it was merged.
Change subject: [bugfix] strip right side of text
......................................................................
[bugfix] strip right side of text
See T137637:
BaseBot.userPut() method gives wrong result when trying to add spaces or
newlines at the end of the page. MediaWiki does not respect adding any space
to the end but strips it. Unfortunately userPut() method only checks for
differences including empty spaces at the end and wrongly returns True.
Change-Id: I6bd98b1a6fab744bc111b804a11e100f9e25da06
---
M checkvotes.py
1 file changed, 1 insertion(+), 0 deletions(-)
Approvals:
Xqt: Looks good to me, approved
jenkins-bot: Verified
diff --git a/checkvotes.py b/checkvotes.py
index ac24702..5a7a3d9 100644
--- a/checkvotes.py
+++ b/checkvotes.py
@@ -474,6 +474,7 @@
r'\n#:<s>\1</s> <small>nicht stimmberechtigt
--~~~~</small>\n', [])
text = head + text
+ text = text.rstrip() # TODO: may removed when T137637 is fixed
if self.userPut(page, page.text, text,
summary=self.summary + comment):
for username in userlist:
--
To view, visit https://gerrit.wikimedia.org/r/295119
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I6bd98b1a6fab744bc111b804a11e100f9e25da06
Gerrit-PatchSet: 1
Gerrit-Project: pywikibot/bots/xqbot
Gerrit-Branch: master
Gerrit-Owner: Xqt <i...@gno.de>
Gerrit-Reviewer: Xqt <i...@gno.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
