Bearloga has submitted this change and it was merged.

Change subject: Minor bug fix
......................................................................


Minor bug fix

Change-Id: I98394abdd28329ec64928a762d09b129bc4d8f94
---
M search/dwelltime.R
1 file changed, 2 insertions(+), 1 deletion(-)

Approvals:
  Bearloga: Verified; Looks good to me, approved



diff --git a/search/dwelltime.R b/search/dwelltime.R
index 63f8fb8..8385e11 100644
--- a/search/dwelltime.R
+++ b/search/dwelltime.R
@@ -15,7 +15,8 @@
                            conditionals = "event_action 
IN('searchResultPage','visitPage', 'checkin', 'click')
                                            AND (event_subTest IS NULL OR 
event_subTest IN ('null','baseline'))
                                            AND event_source = 'fulltext'")
-  data <- data[duplicated(data$event_id, fromLast = FALSE), ]; data$event_id 
<- NULL
+  data <- data[order(data$timestamp, decreasing = FALSE), ]
+  data <- data[!duplicated(data$event_id, fromLast = FALSE), ]; data$event_id 
<- NULL
   data$timestamp <- lubridate::ymd_hms(data$timestamp)
   data$action_id <- ifelse(data$action == "searchResultPage", 0, 1)
   

-- 
To view, visit https://gerrit.wikimedia.org/r/295251
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I98394abdd28329ec64928a762d09b129bc4d8f94
Gerrit-PatchSet: 1
Gerrit-Project: wikimedia/discovery/golden
Gerrit-Branch: master
Gerrit-Owner: Bearloga <mpo...@wikimedia.org>
Gerrit-Reviewer: Bearloga <mpo...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to