Paladox has uploaded a new change for review. https://gerrit.wikimedia.org/r/295459
Change subject: Add VE module check to #isSupported ...................................................................... Add VE module check to #isSupported Because if VE isn't installed, VE isn't supported. Bug: T131055 Change-Id: I0198194bff9cca0ba6e5e9343bc32eae67593c0b (cherry picked from commit 8ecf1527714c0173ba84492dc4fbabb3147b5c24) --- M modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js M modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js 2 files changed, 4 insertions(+), 0 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Flow refs/changes/59/295459/1 diff --git a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js index 6fc3dc8..9bd7eee 100644 --- a/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js +++ b/modules/editor/editors/visualeditor/ext.flow.editors.visualeditor.js @@ -197,6 +197,8 @@ var isMobileTarget = ( mw.config.get( 'skin' ) === 'minerva' ); return !!( + mw.loader.getState( 'ext.visualEditor.core' ) && + !isMobileTarget && // ES5 support, from es5-skip.js diff --git a/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js b/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js index be303b6..86e8cbf 100644 --- a/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js +++ b/modules/flow/ui/widgets/editor/editors/mw.flow.ui.VisualEditorWidget.js @@ -44,6 +44,8 @@ var isMobileTarget = ( mw.config.get( 'skin' ) === 'minerva' ); return !!( + mw.loader.getState( 'ext.visualEditor.core' ) && + !isMobileTarget && // ES5 support, from es5-skip.js -- To view, visit https://gerrit.wikimedia.org/r/295459 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I0198194bff9cca0ba6e5e9343bc32eae67593c0b Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Flow Gerrit-Branch: REL1_27 Gerrit-Owner: Paladox <thomasmulhall...@yahoo.com> Gerrit-Reviewer: Esanders <esand...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits