Bearloga has uploaded a new change for review. https://gerrit.wikimedia.org/r/295593
Change subject: Fix new first visit dashboard ...................................................................... Fix new first visit dashboard Patch in response to https://phabricator.wikimedia.org/T134199#2399480 Bug: T134199 Change-Id: I9a4f38b424bb96b42696a3d09299b0d90061dfca --- M functions.R M server.R M ui.R 3 files changed, 7 insertions(+), 3 deletions(-) git pull ssh://gerrit.wikimedia.org:29418/wikimedia/discovery/prince refs/changes/93/295593/1 diff --git a/functions.R b/functions.R index d165efe..68913f7 100644 --- a/functions.R +++ b/functions.R @@ -20,7 +20,8 @@ # Read in first visit clickthrough rates data <- polloi::read_dataset(path = "portal/clickthrough_firstvisit.tsv") data[, -1] <- data[, -1]*100 # first column is always going to be the date - first_visit_ctrs <<- data + data$`language search` <- 0 + first_visit_ctrs <<- as.data.frame(data[, names(action_breakdown)]) return(invisible()) } diff --git a/server.R b/server.R index 9a75079..0b47c21 100644 --- a/server.R +++ b/server.R @@ -48,7 +48,8 @@ polloi::make_dygraph(xlab = "Date", ylab = "Actions (%)", title = "Actions on the first visit to Wikipedia Portal") %>% dyCSS(css = "www/inverse.css") %>% - dyAxis("x", axisLabelFormatter = polloi::custom_axis_formatter, axisLabelWidth = 70) + dyAxis("x", axisLabelFormatter = polloi::custom_axis_formatter, axisLabelWidth = 70) %>% + dyLegend(labelsDiv = "first_visit_legend", show = "always", width = 400) }) output$dwelltime_dygraph <- renderDygraph({ diff --git a/ui.R b/ui.R index a5728b7..db5a8a1 100644 --- a/ui.R +++ b/ui.R @@ -51,7 +51,9 @@ ), tabItem(tabName = "first_visit", polloi::smooth_select("smoothing_first_visit"), - dygraphOutput("first_visit_dygraph"), + div(dygraphOutput("first_visit_dygraph"), + div(id = "first_visit_legend", + style = "height: 60px; padding-top: 30px; padding-left: 20px;")), includeMarkdown("./tab_documentation/first_visit.md") ), tabItem(tabName = "dwell_data", -- To view, visit https://gerrit.wikimedia.org/r/295593 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I9a4f38b424bb96b42696a3d09299b0d90061dfca Gerrit-PatchSet: 1 Gerrit-Project: wikimedia/discovery/prince Gerrit-Branch: master Gerrit-Owner: Bearloga <mpo...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
