jenkins-bot has submitted this change and it was merged.
Change subject: Parser: Use LinkRenderer for building ISBN magic links
......................................................................
Parser: Use LinkRenderer for building ISBN magic links
Instead of manually building the <a> tag, use LinkRenderer to create it.
Change-Id: Iaefe85527307a8399e9f52dde58fb2c24c4753c2
---
M includes/parser/Parser.php
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Siebrand: Looks good to me, approved
jenkins-bot: Verified
diff --git a/includes/parser/Parser.php b/includes/parser/Parser.php
index 65dde21..26b4bd9 100644
--- a/includes/parser/Parser.php
+++ b/includes/parser/Parser.php
@@ -1470,10 +1470,14 @@
' ' => '',
'x' => 'X',
] );
- $titleObj = SpecialPage::getTitleFor( 'Booksources',
$num );
- return '<a href="' .
- htmlspecialchars( $titleObj->getLocalURL() ) .
- "\" class=\"internal mw-magiclink-isbn\">ISBN
$isbn</a>";
+ return $this->getLinkRenderer()->makeKnownLink(
+ SpecialPage::getTitleFor( 'Booksources', $num ),
+ "ISBN $isbn",
+ [
+ 'class' => 'internal mw-magiclink-isbn',
+ 'title' => false // suppress title
attribute
+ ]
+ );
} else {
return $m[0];
}
--
To view, visit https://gerrit.wikimedia.org/r/290393
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Iaefe85527307a8399e9f52dde58fb2c24c4753c2
Gerrit-PatchSet: 11
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Legoktm <[email protected]>
Gerrit-Reviewer: Cscott <[email protected]>
Gerrit-Reviewer: Fomafix
Gerrit-Reviewer: Jackmcbarn <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Siebrand <[email protected]>
Gerrit-Reviewer: Tim Starling <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
