Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295731
Change subject: phpcs: Enable
MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines and make pass
......................................................................
phpcs: Enable MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines and
make pass
Change-Id: I8049b8c1cb5b4a304834c106655a46c24d2adc29
---
M ProofreadPage.body.php
M ProofreadPage.namespaces.php
M includes/index/EditProofreadIndexPage.php
M includes/index/ProofreadIndexValue.php
M includes/index/oai/ProofreadIndexOaiError.php
M includes/index/oai/ProofreadIndexOaiRecord.php
M includes/index/oai/ProofreadIndexOaiSets.php
M includes/index/oai/SpecialProofreadIndexOai.php
M includes/index/oai/SpecialProofreadIndexOaiSchema.php
M includes/page/PageContent.php
M phpcs.xml
M tests/includes/page/PageContentTest.php
12 files changed, 0 insertions(+), 25 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/ProofreadPage
refs/changes/31/295731/1
diff --git a/ProofreadPage.body.php b/ProofreadPage.body.php
index 7073a8f..ed727a3 100644
--- a/ProofreadPage.body.php
+++ b/ProofreadPage.body.php
@@ -689,7 +689,6 @@
return true;
}
-
/**
* @param $updater DatabaseUpdater
* @return bool
diff --git a/ProofreadPage.namespaces.php b/ProofreadPage.namespaces.php
index b9c6cfc..51e7f8e 100644
--- a/ProofreadPage.namespaces.php
+++ b/ProofreadPage.namespaces.php
@@ -233,7 +233,6 @@
'index_talk' => 'Discussioni_indice'
];
-
/** Kannada (ಕನ್ನಡ) */
$proofreadPageNamespacesNames['kn'] = [
'page' => 'ಪುಟ',
diff --git a/includes/index/EditProofreadIndexPage.php
b/includes/index/EditProofreadIndexPage.php
index ac69e63..aa07545 100644
--- a/includes/index/EditProofreadIndexPage.php
+++ b/includes/index/EditProofreadIndexPage.php
@@ -71,7 +71,6 @@
Xml::label( $entry->getLabel(), $key )
);
-
$help = $entry->getHelp();
if ( $help !== '' ) {
$out->addHTML( Html::element( 'span', [ 'title' =>
$help, 'class' => 'prp-help-field' ] ) );
@@ -180,7 +179,6 @@
return $value;
}
-
/**
* Check the validity of the page
diff --git a/includes/index/ProofreadIndexValue.php
b/includes/index/ProofreadIndexValue.php
index d0b7933..b2b8954 100644
--- a/includes/index/ProofreadIndexValue.php
+++ b/includes/index/ProofreadIndexValue.php
@@ -111,7 +111,6 @@
}
}
-
/**
* A string value of an index entry
*/
@@ -176,7 +175,6 @@
return 'string';
}
}
-
/**
* A number value of an index entry
@@ -246,7 +244,6 @@
return is_numeric( $value );
}
}
-
/**
* A page value of an index entry
@@ -325,7 +322,6 @@
}
}
-
/**
* A Langcode value of an index entry
*/
@@ -336,7 +332,6 @@
* @var string
*/
protected $value;
-
/**
* Set the value
@@ -371,7 +366,6 @@
return Language::isValidBuiltInCode( $value );
}
}
-
/**
* An identifier value of an index entry
@@ -446,7 +440,6 @@
}
}
-
/**
* An ISSN value of an index entry
*/
@@ -485,7 +478,6 @@
return preg_match( self::VALIDATION_REGEX, $value );
}
}
-
/**
* An LCCN value of an index entry
@@ -527,7 +519,6 @@
}
}
-
/**
* An LCCN value of an index entry
*/
@@ -567,7 +558,6 @@
}
}
-
/**
* An ARC value of an index entry
*/
@@ -606,7 +596,6 @@
return is_numeric( $value );
}
}
-
/**
* An ARK value of an index entry
diff --git a/includes/index/oai/ProofreadIndexOaiError.php
b/includes/index/oai/ProofreadIndexOaiError.php
index c7b985d..752e315 100644
--- a/includes/index/oai/ProofreadIndexOaiError.php
+++ b/includes/index/oai/ProofreadIndexOaiError.php
@@ -18,7 +18,6 @@
* The content of this file use some code from OAIRepo Mediawiki extension.
*/
-
/**
* OAI error
*/
diff --git a/includes/index/oai/ProofreadIndexOaiRecord.php
b/includes/index/oai/ProofreadIndexOaiRecord.php
index 0db4b1d..8ddade8 100644
--- a/includes/index/oai/ProofreadIndexOaiRecord.php
+++ b/includes/index/oai/ProofreadIndexOaiRecord.php
@@ -21,7 +21,6 @@
* @ingroup SpecialPage
*/
-
/**
* Provide OAI record of an index page
*/
diff --git a/includes/index/oai/ProofreadIndexOaiSets.php
b/includes/index/oai/ProofreadIndexOaiSets.php
index af4b552..77e7d2a 100644
--- a/includes/index/oai/ProofreadIndexOaiSets.php
+++ b/includes/index/oai/ProofreadIndexOaiSets.php
@@ -20,7 +20,6 @@
* @file
*/
-
/**
* Manage sets-related features
*/
diff --git a/includes/index/oai/SpecialProofreadIndexOai.php
b/includes/index/oai/SpecialProofreadIndexOai.php
index 4ccfe07..42f49e0 100644
--- a/includes/index/oai/SpecialProofreadIndexOai.php
+++ b/includes/index/oai/SpecialProofreadIndexOai.php
@@ -21,7 +21,6 @@
* @ingroup SpecialPage
*/
-
/**
* A special page to return metadata of index pages in RDF/XML
* @see http://www.openarchives.org/OAI/openarchivesprotocol.html
diff --git a/includes/index/oai/SpecialProofreadIndexOaiSchema.php
b/includes/index/oai/SpecialProofreadIndexOaiSchema.php
index 1d418af..9249a19 100644
--- a/includes/index/oai/SpecialProofreadIndexOaiSchema.php
+++ b/includes/index/oai/SpecialProofreadIndexOaiSchema.php
@@ -21,7 +21,6 @@
* @ingroup SpecialPage
*/
-
/**
* A special page to return XML schema used by ProofreadPage OAi-PMH API
*/
diff --git a/includes/page/PageContent.php b/includes/page/PageContent.php
index cbd67ab..5417b22 100644
--- a/includes/page/PageContent.php
+++ b/includes/page/PageContent.php
@@ -238,7 +238,6 @@
$title->getText()
);
-
// html container
$html = Html::openElement( 'div', [ 'class' =>
'prp-page-qualityheader quality' . $this->level->getLevel() ] ) .
wfMessage( 'proofreadpage_quality' .
$this->level->getLevel() . '_message' )->inContentLanguage()->parse() .
diff --git a/phpcs.xml b/phpcs.xml
index 5f3b8cd..bf496eb 100644
--- a/phpcs.xml
+++ b/phpcs.xml
@@ -12,9 +12,6 @@
<property name="ignoreList" type="array"
value="$proofreadPageNamespacesNames" />
</properties>
</rule>
- <rule ref="MediaWiki.WhiteSpace.MultipleEmptyLines.MultipleEmptyLines">
- <severity>0</severity>
- </rule>
<file>.</file>
<arg name="extensions" value="php" />
<exclude-pattern>node_modules/</exclude-pattern>
diff --git a/tests/includes/page/PageContentTest.php
b/tests/includes/page/PageContentTest.php
index 16087ad..c235c87 100644
--- a/tests/includes/page/PageContentTest.php
+++ b/tests/includes/page/PageContentTest.php
@@ -35,7 +35,6 @@
]
] );
-
$this->requestContext = new RequestContext( new FauxRequest() );
$this->requestContext->setTitle( Title::makeTitle( 250,
'Test.jpg' ) );
$this->requestContext->setUser( $user );
--
To view, visit https://gerrit.wikimedia.org/r/295731
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8049b8c1cb5b4a304834c106655a46c24d2adc29
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/ProofreadPage
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
