Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/295732
Change subject: Mark the APIEditBeforeSave hook as deprecated
......................................................................
Mark the APIEditBeforeSave hook as deprecated
Change-Id: I6947d5373aa33224141f8d21cf3a1ee1f641d952
---
M docs/hooks.txt
M includes/api/ApiEditPage.php
2 files changed, 3 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core
refs/changes/32/295732/1
diff --git a/docs/hooks.txt b/docs/hooks.txt
index fa664c3..c0c01f4 100644
--- a/docs/hooks.txt
+++ b/docs/hooks.txt
@@ -371,7 +371,8 @@
&$message: API usage message to die with, as a message key or array
as accepted by ApiBase::dieUsageMsg.
-'APIEditBeforeSave': Before saving a page with api.php?action=edit, after
+'APIEditBeforeSave': DEPRECATED! Use EditFilterMergedContent instead.
+Before saving a page with api.php?action=edit, after
processing request parameters. Return false to let the request fail, returning
an error message or an <edit result="Failure"> tag if $resultArr was filled.
Unlike for example 'EditFilterMergedContent' this also being run on undo.
diff --git a/includes/api/ApiEditPage.php b/includes/api/ApiEditPage.php
index d3d7a4d..62ba860 100644
--- a/includes/api/ApiEditPage.php
+++ b/includes/api/ApiEditPage.php
@@ -401,6 +401,7 @@
// Run hooks
// Handle APIEditBeforeSave parameters
$r = [];
+ // Deprecated in favour of EditFilterMergedContent
if ( !Hooks::run( 'APIEditBeforeSave', [ $ep, $content, &$r ] )
) {
if ( count( $r ) ) {
$r['result'] = 'Failure';
--
To view, visit https://gerrit.wikimedia.org/r/295732
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I6947d5373aa33224141f8d21cf3a1ee1f641d952
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
