Ema has submitted this change and it was merged. Change subject: diamond TCP collector: add TFO-related metrics ......................................................................
diamond TCP collector: add TFO-related metrics The diamond TCP collector exposes a configuration option allowing to specify additional TCP metrics to be reported. This commit adds the following TFO-related metrics: - TCPFastOpenActive - TCPFastOpenActiveFail - TCPFastOpenPassive - TCPFastOpenPassiveFail - TCPFastOpenCookieReqd - TCPFastOpenListenOverflow - TCPSynRetrans - TCPOrigDataSent See https://wikitech.wikimedia.org/wiki/TCP_Fast_Open for an explanation of those. Bug: T108827 Change-Id: I78253380f4dee42085bcb2925b2a281e6cafae34 --- M modules/diamond/manifests/init.pp 1 file changed, 18 insertions(+), 1 deletion(-) Approvals: Filippo Giunchedi: Looks good to me, but someone else must approve Ema: Verified; Looks good to me, approved diff --git a/modules/diamond/manifests/init.pp b/modules/diamond/manifests/init.pp index f3de736..bb489c1 100644 --- a/modules/diamond/manifests/init.pp +++ b/modules/diamond/manifests/init.pp @@ -117,7 +117,24 @@ diamond::collector { 'Network': } - diamond::collector { 'TCP': } + diamond::collector { 'TCP': + settings => { + allowed_names => [ + 'ListenOverflows', 'ListenDrops', + 'TCPLoss', 'TCPTimeouts', + 'TCPFastRetrans', 'TCPLostRetransmit', + 'TCPForwardRetrans', 'TCPSlowStartRetrans', + 'CurrEstab', 'TCPAbortOnMemory', + 'TCPBacklogDrop', 'AttemptFails', + 'EstabResets', 'InErrs', + 'ActiveOpens', 'PassiveOpens', + 'TCPFastOpenActive', 'TCPFastOpenActiveFail', + 'TCPFastOpenPassive', 'TCPFastOpenPassiveFail', + 'TCPFastOpenListenOverflow', 'TCPFastOpenCookieReqd', + 'TCPSynRetrans', 'TCPOrigDataSent' + ] + } + } diamond::collector { 'Ntpd': } -- To view, visit https://gerrit.wikimedia.org/r/295900 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I78253380f4dee42085bcb2925b2a281e6cafae34 Gerrit-PatchSet: 3 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ema <e...@wikimedia.org> Gerrit-Reviewer: BBlack <bbl...@wikimedia.org> Gerrit-Reviewer: Ema <e...@wikimedia.org> Gerrit-Reviewer: Filippo Giunchedi <fgiunch...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
