jenkins-bot has submitted this change and it was merged. Change subject: Align Hovercards' Less to Coding Standards ......................................................................
Align Hovercards' Less to Coding Standards Aligning Hovercards' Less to Coding Standards and also variablize `linkpreview-title` font-family. Change-Id: I11f2d71ce50dcd0fe47f3c5c528779e29a81cbc6 --- M resources/ext.popups.renderer/LinkPreview.less 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: Bmansurov: Looks good to me, approved jenkins-bot: Verified diff --git a/resources/ext.popups.renderer/LinkPreview.less b/resources/ext.popups.renderer/LinkPreview.less index 44f6677..4dd2e3b 100644 --- a/resources/ext.popups.renderer/LinkPreview.less +++ b/resources/ext.popups.renderer/LinkPreview.less @@ -1,10 +1,10 @@ @import "minerva.variables"; .drawer.linkpreview { + background-color: #fff; position: fixed; - background-color: white; - text-align: left; padding: 0 15px 20px; + text-align: left; &.loading { padding: 10px; @@ -12,18 +12,18 @@ } .linkpreview-overlay { + background-color: rgba( 0, 0, 0, 0.1 ); + background-attachment: fixed; position: fixed; top: 0; left: 0; height: 100%; width: 100%; z-index: @z-indexOverlay; - background-color: rgba(0,0,0,0.1); - background-attachment: fixed; } .linkpreview-title { - font-family: Georgia; + font-family: @fontFamilyHeading; font-size: 22px; margin-top: 20px; line-height: 1; @@ -44,7 +44,7 @@ } } -@media all and (min-width: @deviceWidthTablet) { +@media all and ( min-width: @deviceWidthTablet ) { .drawer.linkpreview { padding-left: 30px; padding-right: 30px; -- To view, visit https://gerrit.wikimedia.org/r/295923 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I11f2d71ce50dcd0fe47f3c5c528779e29a81cbc6 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Popups Gerrit-Branch: master Gerrit-Owner: VolkerE <volke...@wikimedia.org> Gerrit-Reviewer: Bmansurov <bmansu...@wikimedia.org> Gerrit-Reviewer: Jdlrobson <jrob...@wikimedia.org> Gerrit-Reviewer: Jhobs <jhob...@wikimedia.org> Gerrit-Reviewer: Nirzar <npangar...@wikimedia.org> Gerrit-Reviewer: jenkins-bot <> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits