jenkins-bot has submitted this change and it was merged.

Change subject: Make a symbol on the "Show help" button translatable
......................................................................


Make a symbol on the "Show help" button translatable

Change-Id: I60ae368f59203f63fb352ec861db5d75d488f8fa
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.RevisionSlider.init.js
4 files changed, 4 insertions(+), 1 deletion(-)

Approvals:
  Jakob: Checked; Looks good to me, but someone else must approve
  Siebrand: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/extension.json b/extension.json
index 25c19c9..11a1b7a 100644
--- a/extension.json
+++ b/extension.json
@@ -40,6 +40,7 @@
                                "mediawiki.api.options"
                        ],
                        "messages": [
+                               "revisionslider-show-help",
                                "revisionslider-loading-out-of-range",
                                "revisionslider-loading-failed"
                        ],
diff --git a/i18n/en.json b/i18n/en.json
index ed4af13..db4f679 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -18,6 +18,7 @@
     "revisionslider-loading-out-of-range": "The revision slider failed to load 
as the requested revisions are not in the top 500 versions of the page.",
     "revisionslider-arrow-tooltip-newer": "See newer revisions",
     "revisionslider-arrow-tooltip-older": "See older revisions",
+    "revisionslider-show-help": "?",
     "revisionslider-help-dialog-slide1": "The RevisionSlider helps you to 
navigate and compare revisions on the diff page. It is based on a 
[[m:WMDE_Technical_Wishes/Revision_Slider|community wish]] from the 
German-speaking community technical wishlist.",
     "revisionslider-help-dialog-slide2": "Each bar represents an article 
revision. Bars on the top show growth in size of the article, bars on the 
bottom show a reduction. In the image, revision 1 represents added content, 
while revision 2 represents removal of content.",
     "revisionslider-help-dialog-slide3": "<p>To compare certain revisions, 
select the revisions using the yellow and blue pointer.</p><p>The blue pointer 
controls the newer revision, the yellow pointer maps to the older 
revision.</p><p>Move the pointers by drag and drop or click on a bar.</p>",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 56adeae..36e2e9a 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -19,6 +19,7 @@
        "revisionslider-loading-out-of-range": "Message shown if the 
RevisionSlider fails to initially load due to revisions being requested that 
are not in the most recent 500 revisions.",
        "revisionslider-arrow-tooltip-newer": "Text shown after hovering the 
button scrolling to newer revisions.",
        "revisionslider-arrow-tooltip-older": "Text shown after hovering the 
button scrolling to older revisions.",
+       "revisionslider-show-help": "A symbol shown in the \"Show help\" 
button.",
        "revisionslider-help-dialog-slide1": "Text shown on the first slide of 
the help dialog.",
        "revisionslider-help-dialog-slide2": "Text shown on the second slide of 
the help dialog.",
        "revisionslider-help-dialog-slide3": "Text shown on the third slide of 
the help dialog.",
diff --git a/modules/ext.RevisionSlider.init.js 
b/modules/ext.RevisionSlider.init.js
index 77fd306..680dad0 100644
--- a/modules/ext.RevisionSlider.init.js
+++ b/modules/ext.RevisionSlider.init.js
@@ -35,7 +35,7 @@
                                                .click( function () {
                                                        
mw.libs.revisionSlider.HelpDialog.show();
                                                } )
-                                               .text( '?' )
+                                               .text( mw.message( 
'revisionslider-show-help' ).text() )
                                                .addClass( 'mw-show-help' )
                                );
                        } catch ( err ) {

-- 
To view, visit https://gerrit.wikimedia.org/r/295916
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I60ae368f59203f63fb352ec861db5d75d488f8fa
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to