jenkins-bot has submitted this change and it was merged.
Change subject: TranslateDeleteJob: Fix result of errors value when deletions
fail
......................................................................
TranslateDeleteJob: Fix result of errors value when deletions fail
doDeleteArticle() returns a bool so it isn't very helpful to log this value
as an error. For some reason, it also seems to be either ignored by the
list=logevents API or it's not even inserted. So switch to use
doDeleteArticleReal() which returns a Status object so that we can properly
log the errors. Discovered while looking into T138571.
Change-Id: Ie04b7049accf5db4e79f136135d3c206e504e6a6
---
M tag/TranslateDeleteJob.php
1 file changed, 3 insertions(+), 3 deletions(-)
Approvals:
Nikerabbit: Looks good to me, approved
jenkins-bot: Verified
diff --git a/tag/TranslateDeleteJob.php b/tag/TranslateDeleteJob.php
index de4d418..a5e6827 100644
--- a/tag/TranslateDeleteJob.php
+++ b/tag/TranslateDeleteJob.php
@@ -59,11 +59,11 @@
$error = '';
$wikipage = new WikiPage( $title );
- $ok = $wikipage->doDeleteArticle( "{$summary}: $reason", false,
0, true, $error, $user );
- if ( !$ok ) {
+ $status = $wikipage->doDeleteArticleReal( "{$summary}:
$reason", false, 0, true, $error, $user );
+ if ( !$status->isGood() ) {
$params = array(
'target' => $base,
- 'error' => $ok,
+ 'errors' => $status->getErrorsArray(),
);
$type = $this->getFull() ? 'deletefnok' : 'deletelnok';
--
To view, visit https://gerrit.wikimedia.org/r/295945
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie04b7049accf5db4e79f136135d3c206e504e6a6
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
