WMDE-leszek has submitted this change and it was merged.
Change subject: Use username for username label
......................................................................
Use username for username label
After changing this several times to address concerns related to
GENDER, decided to use the mediawiki standard here also used
in the core code. For translators a hint was added that GENDER
is not supported here so an appropriate translation should be
chosen by them.
Bug: T136367
Change-Id: Icc2a8e6fc08761367c4ab6bb2a446262f8aa86e6
---
M extension.json
M i18n/en.json
M i18n/qqq.json
M modules/ext.RevisionSlider.RevisionListView.js
4 files changed, 4 insertions(+), 4 deletions(-)
Approvals:
WMDE-leszek: Looks good to me, approved
jenkins-bot: Verified
diff --git a/extension.json b/extension.json
index 44008d6..93531fb 100644
--- a/extension.json
+++ b/extension.json
@@ -122,7 +122,7 @@
"revisionslider-label-date",
"revisionslider-label-page-size",
"revisionslider-label-change-size",
- "revisionslider-label-edited-by",
+ "revisionslider-label-username",
"revisionslider-label-comment"
],
"dependencies": [
diff --git a/i18n/en.json b/i18n/en.json
index d5450fd..10167b3 100644
--- a/i18n/en.json
+++ b/i18n/en.json
@@ -12,7 +12,7 @@
"revisionslider-label-page-size": "<strong>Page size:</strong> $1
{{PLURAL:$2|byte|bytes}}",
"revisionslider-label-change-size": "<strong>Change size:</strong> $1
{{PLURAL:$2|byte|bytes}}",
"revisionslider-label-comment": "Comment: ",
- "revisionslider-label-edited-by": "<strong>Edited by:</strong> $1",
+ "revisionslider-label-username": "<strong>Username:</strong> $1",
"revisionslider-loading-placeholder": "The revision slider is loading.",
"revisionslider-loading-failed": "The revision slider failed to load.",
"revisionslider-loading-out-of-range": "The revision slider failed to load
as the requested revisions are not in the top 500 versions of the page.",
diff --git a/i18n/qqq.json b/i18n/qqq.json
index 4e0e70a..53fe345 100644
--- a/i18n/qqq.json
+++ b/i18n/qqq.json
@@ -13,7 +13,7 @@
"revisionslider-label-page-size": "Label describing the size of this
revision.\nParameters:\n* $1 - Formatted article size.\n* $2 - Article size as
raw number.",
"revisionslider-label-change-size": "Label describing the size of the
change compared to the revision before.\nParameters:\n* $1 - Formatted change
size colored with markup.\n* $2 - Change size as raw number.",
"revisionslider-label-comment": "Label showing the edit summary of a
revision.",
- "revisionslider-label-edited-by": "Gender-neutral label showing this
revision's author's username.\nParameters:\n* $1 - Username.",
+ "revisionslider-label-username": "Label for the revision's author's
username.\n{{doc-important|<nowiki>{{</nowiki>[[Gender|GENDER]]<nowiki>}}</nowiki>
is '''NOT''' supported.}}\n\nParameters:\n* $1 -
Username.\n\n{{Identical|Username}}",
"revisionslider-loading-placeholder": "Message shown while the
RevisionSlider is still loading on a diff page. Once loaded the message is
removed.",
"revisionslider-loading-failed": "Message shown if the RevisionSlider
fails to initially load.",
"revisionslider-loading-out-of-range": "Message shown if the
RevisionSlider fails to initially load due to revisions being requested that
are not in the most recent 500 revisions.",
diff --git a/modules/ext.RevisionSlider.RevisionListView.js
b/modules/ext.RevisionSlider.RevisionListView.js
index 6c19f0d..21c7d22 100644
--- a/modules/ext.RevisionSlider.RevisionListView.js
+++ b/modules/ext.RevisionSlider.RevisionListView.js
@@ -140,7 +140,7 @@
),
rev.getUser() ?
$( '<bdi>' ).append( $( '<p>'
).append(
- mw.message(
'revisionslider-label-edited-by', mw.html.escape( rev.getUser() ) ).parseDom()
+ mw.message(
'revisionslider-label-username', mw.html.escape( rev.getUser() ) ).parseDom()
) )
: '',
this.makeCommentLine( rev ),
--
To view, visit https://gerrit.wikimedia.org/r/294066
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Icc2a8e6fc08761367c4ab6bb2a446262f8aa86e6
Gerrit-PatchSet: 5
Gerrit-Project: mediawiki/extensions/RevisionSlider
Gerrit-Branch: master
Gerrit-Owner: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: Addshore <addshorew...@gmail.com>
Gerrit-Reviewer: Gabriel Birke <gabriel.bi...@wikimedia.de>
Gerrit-Reviewer: Jakob <jakob.warkot...@wikimedia.de>
Gerrit-Reviewer: Kai Nissen (WMDE) <kai.nis...@wikimedia.de>
Gerrit-Reviewer: Legoktm <legoktm.wikipe...@gmail.com>
Gerrit-Reviewer: Nemo bis <federicol...@tiscali.it>
Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: Tobias Gritschacher <tobias.gritschac...@wikimedia.de>
Gerrit-Reviewer: WMDE-Fisch <christoph.fisc...@wikimedia.de>
Gerrit-Reviewer: WMDE-leszek <leszek.mani...@wikimedia.de>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
