jenkins-bot has submitted this change and it was merged.
Change subject: Improve accuracy of message status updates
......................................................................
Improve accuracy of message status updates
Test plan for issue 1:
1. Find a fuzzy or untranslated message
2. Keep making edits to the message and save them
3. Observe that the statsbar stays in the state it is after first edit
Without this patch, the amount of translated messages would keep growing
without limit, exceeding 100% easily.
Test plan for issue 2:
1. Make a message fuzzy and reload Special:Translate
2. In page mode/proofread mode (separately) edit the message
3. Observer that the yellow label goes away after saving
Without this patch, the yellow label with a clock symbol would stay even
after saving.
Bug: T62949
Change-Id: Ic14b70d72750ec8645d2b67ce0d6b2b98eb78556
---
M resources/js/ext.translate.editor.js
M resources/js/ext.translate.pagemode.js
M resources/js/ext.translate.proofread.js
3 files changed, 14 insertions(+), 8 deletions(-)
Approvals:
Purodha: Looks good to me, but someone else must approve
Glaisher: Looks good to me, approved
jenkins-bot: Verified
diff --git a/resources/js/ext.translate.editor.js
b/resources/js/ext.translate.editor.js
index 69bdf27..db63eb4 100644
--- a/resources/js/ext.translate.editor.js
+++ b/resources/js/ext.translate.editor.js
@@ -157,8 +157,8 @@
);
this.$messageItem
- .addClass( 'translated' )
- .removeClass( 'untranslated' );
+ .removeClass( 'untranslated translated fuzzy
proofread' )
+ .addClass( 'translated' );
this.dirty = false;
@@ -167,6 +167,8 @@
'change',
[ 'translated',
this.message.properties.status ]
);
+
+ this.message.properties.status = 'translated';
// TODO: Update any other statsbar for the same
group in the page.
}
},
diff --git a/resources/js/ext.translate.pagemode.js
b/resources/js/ext.translate.pagemode.js
index 7d564d0..8f665a3 100644
--- a/resources/js/ext.translate.pagemode.js
+++ b/resources/js/ext.translate.pagemode.js
@@ -44,6 +44,10 @@
pagemode.$message.find(
'.tux-pagemode-translation' )
.removeClass( 'highlight' );
pagemode.message.translation =
translation;
+
+ pagemode.$message.find(
'.tux-pagemode-status' )
+ .removeClass( 'translated fuzzy
proofread untranslated' )
+ .addClass(
pagemode.message.properties.status );
}
} );
diff --git a/resources/js/ext.translate.proofread.js
b/resources/js/ext.translate.proofread.js
index c615bf3..43e8ecb 100644
--- a/resources/js/ext.translate.proofread.js
+++ b/resources/js/ext.translate.proofread.js
@@ -55,12 +55,10 @@
.text( translation );
proofread.message.translation =
translation;
proofread.markSelfTranslation();
- // Update stats - to translated state
from current state.
- $( '.tux-action-bar .tux-statsbar' )
- .trigger(
- 'change',
- [ 'translated',
proofread.message.properties.status ]
- );
+
+ proofread.$message.find(
'.tux-proofread-status' )
+ .removeClass( 'translated fuzzy
proofread untranslated' )
+ .addClass(
proofread.message.properties.status );
}
} );
@@ -222,6 +220,8 @@
[ 'proofread',
message.properties.status ]
);
+ message.properties.status = 'proofread';
+
if ( mw.track ) {
mw.track(
'ext.translate.event.proofread', message );
}
--
To view, visit https://gerrit.wikimedia.org/r/294070
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic14b70d72750ec8645d2b67ce0d6b2b98eb78556
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Purodha <puro...@blissenbach.org>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
