jenkins-bot has submitted this change and it was merged.

Change subject: Improve statsbar updates
......................................................................


Improve statsbar updates

Message can be in one of the following status:
* untranslated
* translated
* fuzzy
* proofread (implies translated)

Handle updates accordingly.

Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
---
M resources/js/ext.translate.statsbar.js
1 file changed, 4 insertions(+), 2 deletions(-)

Approvals:
  Glaisher: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/resources/js/ext.translate.statsbar.js 
b/resources/js/ext.translate.statsbar.js
index f3e24ec..4535063 100644
--- a/resources/js/ext.translate.statsbar.js
+++ b/resources/js/ext.translate.statsbar.js
@@ -48,7 +48,8 @@
                        statsbar.$statsBar.on( 'change', function ( event, to, 
from ) {
                                for ( i = 0; i < languageStats.length; i++ ) {
                                        if ( languageStats[ i ].group === 
statsbar.group ) {
-                                               if ( to === 'translated' && 
from === 'untranslated' ) {
+                                               // Changing a proofread message 
does not create a new translation
+                                               if ( to === 'translated' && 
from !== 'proofread' ) {
                                                        languageStats[ i 
].translated++;
                                                }
                                                if ( to === 'proofread' ) {
@@ -64,7 +65,8 @@
                                                if ( from === 'proofread' ) {
                                                        languageStats[ i 
].proofread--;
                                                }
-                                               if ( from === 'translated' ) {
+                                               // Proofreading a message does 
not remove translation
+                                               if ( from === 'translated' && 
to !== 'proofread' ) {
                                                        languageStats[ i 
].translated--;
                                                }
                                                break;

-- 
To view, visit https://gerrit.wikimedia.org/r/294071
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Ied2e57bb202e8eb082068069c8a808649bf43c9d
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/Translate
Gerrit-Branch: master
Gerrit-Owner: Nikerabbit <niklas.laxst...@gmail.com>
Gerrit-Reviewer: Glaisher <glaisher.w...@gmail.com>
Gerrit-Reviewer: Santhosh <santhosh.thottin...@gmail.com>
Gerrit-Reviewer: Siebrand <siebr...@kitano.nl>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to