Alexandros Kosiaris has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296377

Change subject: otrs: Replace EXTERNAL_NETWORKS
......................................................................

otrs: Replace EXTERNAL_NETWORKS

The use of EXTERNAL_NETWORKS in OTRS SMTP ferm rule was always
misguided. Limit the rule to what is actually the smallest possible host
set, that is mx1001 and mx2001, a set that is not expected to change
anytime soon

Change-Id: I74cb2ed6d9b7f2f3dc2b9fadae4baa72d6001f47
---
M modules/role/manifests/otrs/webserver.pp
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/77/296377/1

diff --git a/modules/role/manifests/otrs/webserver.pp 
b/modules/role/manifests/otrs/webserver.pp
index 4fda246..e895a08 100644
--- a/modules/role/manifests/otrs/webserver.pp
+++ b/modules/role/manifests/otrs/webserver.pp
@@ -51,7 +51,7 @@
     ferm::service { 'otrs_smtp':
         proto  => 'tcp',
         port   => '25',
-        srange => '($EXTERNAL_NETWORKS)',
+        srange => '@resolve((mx1001.wikimedia.org mx2001.wikimedia.org))',
     }
 
     monitoring::service { 'smtp':

-- 
To view, visit https://gerrit.wikimedia.org/r/296377
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I74cb2ed6d9b7f2f3dc2b9fadae4baa72d6001f47
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to