Jforrester has uploaded a new change for review.
https://gerrit.wikimedia.org/r/296761
Change subject: Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters
work
......................................................................
Follow-up e2f6d798: Make MWTemplateModel#addPromptedParameters work
Change-Id: I27e82aed207e1352ccb5f5a177fd53d5c1868c42
---
M modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
1 file changed, 9 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/VisualEditor
refs/changes/61/296761/1
diff --git a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
index e735dd7..467da06 100644
--- a/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
+++ b/modules/ve-mw/dm/models/ve.dm.MWTemplateModel.js
@@ -291,18 +291,20 @@
* @inheritdoc
*/
ve.dm.MWTemplateModel.prototype.addPromptedParameters = function () {
- var i, len, addedCount = 0,
+ var i, len, name,
+ addedCount = 0,
spec = this.getSpec(),
names = spec.getParameterNames();
for ( i = 0, len = names.length; i < len; i++ ) {
+ name = names[ i ];
if (
- !this.params[ name ] &&
- (
- spec.isParameterRequired( names[ i ] )
||
- spec.isParameterSuggested( names[ i ] )
- )
- ) {
+ !this.params[ name ] &&
+ (
+ spec.isParameterRequired( name ) ||
+ spec.isParameterSuggested( name )
+ )
+ ) {
this.addParameter( new ve.dm.MWParameterModel( this,
names[ i ] ) );
addedCount++;
}
--
To view, visit https://gerrit.wikimedia.org/r/296761
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I27e82aed207e1352ccb5f5a177fd53d5c1868c42
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/VisualEditor
Gerrit-Branch: master
Gerrit-Owner: Jforrester <jforres...@wikimedia.org>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
