Niedzielski has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296942

Change subject: Update Feed strings
......................................................................

Update Feed strings

• Promote experimental strings from no_translate and add qq
  descriptions.

• Change suggestion terminology to cards.

• Remove unused demo string.

Change-Id: I32f7ca64e578048380fe01849a52de8439c42dd0
---
M app/src/main/res/values-qq/strings.xml
M app/src/main/res/values/strings.xml
M app/src/main/res/values/strings_no_translate.xml
3 files changed, 27 insertions(+), 20 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/apps/android/wikipedia 
refs/changes/42/296942/1

diff --git a/app/src/main/res/values-qq/strings.xml 
b/app/src/main/res/values-qq/strings.xml
index 68a482d..c2027be 100644
--- a/app/src/main/res/values-qq/strings.xml
+++ b/app/src/main/res/values-qq/strings.xml
@@ -408,4 +408,15 @@
   <string name="view_main_page_card_subtitle">Message indicating that the user 
will be shown the project\'s main page for the current date. The \"%s\" symbol 
is replaced with the current date.</string>
   <string name="menu_feed_card_dismiss">Menu item used for hiding a certain 
item in the list of feed cards.</string>
   <string name="menu_feed_card_dismissed">Message to inform the user that the 
selected item has been hidden.</string>
+  <string name="feed">Menu item label for discovering Feed cards.</string>
+  <string name="view_card_footer_button">Feed card button label for requesting 
more similar cards.</string>
+  <string name="most_read_list_card_title">Feed card title for recently 
popular articles.</string>
+  <string name="most_read_list_card_footer">Feed card button label for 
requesting more recently popular articles.</string>
+  <string name="view_static_card_icon_content_description">Feed card icon 
description for use when the icon cannot be seen and acessibility.</string>
+  <string name="view_card_news_title">Feed card title for news 
articles.</string>
+  <string name="view_card_news_footer_text">Feed card button label for 
requesting more news articles.</string>
+  <plurals name="view_continue_reading_card_subtitle">
+    <item quantity="one">Phrase for one day ago.</item>
+    <item quantity="other">Phrase for more than one day ago.</item>
+  </plurals>
 </resources>
diff --git a/app/src/main/res/values/strings.xml 
b/app/src/main/res/values/strings.xml
index d1878e7..e283c20 100644
--- a/app/src/main/res/values/strings.xml
+++ b/app/src/main/res/values/strings.xml
@@ -322,7 +322,19 @@
     <string name="view_random_card_subtitle">Read a random article from %s 
Wikipedia</string>
     <string name="view_main_page_card_title">Today on %s Wikipedia</string>
     <string name="view_main_page_card_subtitle">Main page on %s</string>
-    <string name="menu_feed_card_dismiss">Hide this suggestion</string>
-    <string name="menu_feed_card_dismissed">Suggestion hidden.</string>
+    <string name="menu_feed_card_dismiss">Hide this card</string>
+    <string name="menu_feed_card_dismissed">Card hidden.</string>
+
+    <string name="feed">Explore Wikipedia</string>
+    <string name="view_card_footer_button">See more</string>
+    <string name="most_read_list_card_title">Trending</string>
+    <string name="most_read_list_card_footer">MORE LIKE THIS</string>
+    <string name="view_static_card_icon_content_description">Card icon</string>
+    <string name="view_card_news_title">In the news</string>
+    <string name="view_card_news_footer_text">More current events</string>
+    <plurals name="view_continue_reading_card_subtitle">
+        <item quantity="one">1 day ago</item>
+        <item quantity="other">%d days ago</item>
+    </plurals>
     <!-- /The Feed -->
-</resources>
+</resources>
\ No newline at end of file
diff --git a/app/src/main/res/values/strings_no_translate.xml 
b/app/src/main/res/values/strings_no_translate.xml
index 405f754..268164c 100644
--- a/app/src/main/res/values/strings_no_translate.xml
+++ b/app/src/main/res/values/strings_no_translate.xml
@@ -41,28 +41,12 @@
     <!-- /Crash reporter -->
 
     <!-- The Feed -->
-    <!-- TODO: [Feed] move translatable strings to strings.xml. -->
-    <string name="feed">Explore Wikipedia</string>
     <string name="activity_feed_title">@string/feed</string>
     <string name="nav_item_feed">@string/feed</string>
-    <string name="view_card_footer_button">See more</string>
-    <string name="most_read_list_card_title">Trending</string>
-    <string name="most_read_list_card_footer">MORE LIKE THIS</string>
-    <string name="view_static_card_icon_content_description">Card icon</string>
-    <string name="view_card_news_title">In the news</string>
-    <string name="view_card_news_footer_text">More current events</string>
     <string 
name="feed_undo_dismiss_card">@string/reading_list_item_delete_undo</string>
-
-    <plurals name="view_continue_reading_card_subtitle">
-        <item quantity="one">1 day ago</item>
-        <item quantity="other">%d days ago</item>
-    </plurals>
 
     <!-- Experimental English-only features -->
     <string name="view_featured_article_card_title">Featured article</string>
     <string name="view_featured_article_footer_save_button_label">Save</string>
-
     <!-- /The Feed -->
-
-    <string name="lorem_ipsum">Lorem ipsum dolor sit amet, consectetur 
adipiscing elit, sed do eiusmod tempor incididunt ut labore et dolore magna 
aliqua. Ut enim ad minim veniam, quis nostrud exercitation ullamco laboris nisi 
ut aliquip ex ea commodo consequat. Duis aute irure dolor in reprehenderit in 
voluptate velit esse cillum dolore eu fugiat nulla pariatur. Excepteur sint 
occaecat cupidatat non proident, sunt in culpa qui officia deserunt mollit anim 
id est laborum.</string>
-</resources>
+</resources>
\ No newline at end of file

-- 
To view, visit https://gerrit.wikimedia.org/r/296942
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I32f7ca64e578048380fe01849a52de8439c42dd0
Gerrit-PatchSet: 1
Gerrit-Project: apps/android/wikipedia
Gerrit-Branch: master
Gerrit-Owner: Niedzielski <sniedziel...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to