Hello Nuria, I'd like you to do a code review. Please visit
https://gerrit.wikimedia.org/r/296959 to review the following change. Change subject: explicitly specify identity for EL legacy zmq forwarder ...................................................................... explicitly specify identity for EL legacy zmq forwarder We are seeing consumers of the ZeroMQ stream stop receiving events when the forwarder is restarted. My theory is that this has to do with the fact that the identity of the subscriber is not stable across restarts unless explicitly specified. So, specify it explicitly. Change-Id: I7ced5658ecb8d63bd5fbe049bdd1ac2f286d9c5b --- M manifests/role/eventlogging.pp 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/operations/puppet refs/changes/59/296959/1 diff --git a/manifests/role/eventlogging.pp b/manifests/role/eventlogging.pp index 30a29e1..4cd12bf 100644 --- a/manifests/role/eventlogging.pp +++ b/manifests/role/eventlogging.pp @@ -127,7 +127,7 @@ # This forwards the kafka eventlogging-valid-mixed topic to # ZMQ port 8600 for backwards compatibility. eventlogging::service::forwarder { 'legacy-zmq': - input => "${kafka_mixed_uri}&zookeeper_connect=${kafka_zookeeper_url}&auto_commit_enable=False&auto_offset_reset=-1", + input => "${kafka_mixed_uri}&zookeeper_connect=${kafka_zookeeper_url}&auto_commit_enable=False&auto_offset_reset=-1&identity=legacy_zmq", outputs => ["tcp://${eventlogging_host}:8600"], } -- To view, visit https://gerrit.wikimedia.org/r/296959 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I7ced5658ecb8d63bd5fbe049bdd1ac2f286d9c5b Gerrit-PatchSet: 1 Gerrit-Project: operations/puppet Gerrit-Branch: production Gerrit-Owner: Ori.livneh <o...@wikimedia.org> Gerrit-Reviewer: Nuria <nu...@wikimedia.org> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits