Krinkle has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/296976

Change subject: mediawiki.action.edit.stash: Document ignored key codes
......................................................................

mediawiki.action.edit.stash: Document ignored key codes

Follows-up eca800c7f02.

Change-Id: Ic0d9620eb3a5e371cc9825248ebb40abb0dea965
---
M resources/src/mediawiki.action/mediawiki.action.edit.stash.js
1 file changed, 4 insertions(+), 2 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/core 
refs/changes/76/296976/1

diff --git a/resources/src/mediawiki.action/mediawiki.action.edit.stash.js 
b/resources/src/mediawiki.action/mediawiki.action.edit.stash.js
index da27d20..07c7d76 100644
--- a/resources/src/mediawiki.action/mediawiki.action.edit.stash.js
+++ b/resources/src/mediawiki.action/mediawiki.action.edit.stash.js
@@ -64,8 +64,10 @@
                function onTextKeyUp( e ) {
                        // Ignore keystrokes that don't modify text, like 
cursor movements.
                        // See <http://www.javascripter.net/faq/keycodes.htm> 
and
-                       // <http://www.quirksmode.org/js/keys.html>. We don't 
have to be
-                       // exhaustive, because the cost of misfiring is low.
+                       // <http://www.quirksmode.org/js/keys.html>. We don't 
have to be exhaustive,
+                       // because the cost of misfiring is low.
+                       // * Key code 33-40: Page Up/Down, End, Home, arrow 
keys.
+                       // * Key code 16-18: Shift, Ctrl, Alt.
                        if ( ( e.which >= 33 && e.which <= 40 ) || ( e.which >= 
16 && e.which <= 18 ) ) {
                                return;
                        }

-- 
To view, visit https://gerrit.wikimedia.org/r/296976
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic0d9620eb3a5e371cc9825248ebb40abb0dea965
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/core
Gerrit-Branch: master
Gerrit-Owner: Krinkle <krinklem...@gmail.com>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to