MarkAHershberger has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297131
Change subject: Make sure we don't try to use an undefined var as an object
......................................................................
Make sure we don't try to use an undefined var as an object
In a local wiki trying to access .cssRules on the undefined cursheet
resulted in an error kept later js in the Popups extension from being
invoked.
Also, clean up some long lines.
Bug: T139237
Change-Id: I8736992b9a919fc32a7e0cf050708bcc806c877a
---
M skins/ext.headertabs.core.js
1 file changed, 12 insertions(+), 7 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/HeaderTabs
refs/changes/31/297131/1
diff --git a/skins/ext.headertabs.core.js b/skins/ext.headertabs.core.js
index ace26c4..ae88292 100644
--- a/skins/ext.headertabs.core.js
+++ b/skins/ext.headertabs.core.js
@@ -37,19 +37,24 @@
outer:
for (s = 0; s < sheets.length; s++ ) {
var cursheet = sheets[s];
- var rules = cursheet.cssRules ? cursheet.cssRules: cursheet.rules; //
Yay IE
- if( rules ) {
- for (r = 0; r < rules.length; r++) {
- if (rules[r].selectorText !== undefined) {
- if (rules[r].selectorText.toLowerCase() ===
".unselected") { //find ".unselected" rule
- cursheet.deleteRule ?
cursheet.deleteRule(r) : cursheet.removeRule(r); // Yay IE
- break outer;
+ if ( cursheet !== undefined ) {
+ var rules = cursheet.cssRules ? cursheet.cssRules:
cursheet.rules; // Yay IE
+ if( rules ) {
+ for (r = 0; r < rules.length; r++) {
+ if (rules[r].selectorText !== undefined) {
+ //find ".unselected" rule
+ if (rules[r].selectorText.toLowerCase()
=== ".unselected") {
+ // Yay IE
+ cursheet.deleteRule ?
cursheet.deleteRule(r) : cursheet.removeRule(r);
+ break outer;
+ }
}
}
}
}
}
+
/*
* Get links to tabs in Table of Contents to work.
* @author Chad Catlett
--
To view, visit https://gerrit.wikimedia.org/r/297131
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I8736992b9a919fc32a7e0cf050708bcc806c877a
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/HeaderTabs
Gerrit-Branch: master
Gerrit-Owner: MarkAHershberger <m...@nichework.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
