jenkins-bot has submitted this change and it was merged.
Change subject: Namespace the dns-prefetch head element item
......................................................................
Namespace the dns-prefetch head element item
Fix-up for Iae39a92912 (from 2012). The $name element for
OutputPage::addHeadItem() is meant to allow extensions to override head
elements of which there can be only one instance -- e.g., apple-touch-icon. But
there can be multiple <link rel=dns-prefetch> tags, and we don't want
extensions to be clobbering each other's. So use a name that is scoped to
CentralNotice, instead of the generic "dns-prefetch".
Change-Id: I2fb7f3b9f3763f2395cd3120eda5d7e2d2aaebe0
---
M CentralNotice.hooks.php
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Krinkle: Looks good to me, approved
jenkins-bot: Verified
diff --git a/CentralNotice.hooks.php b/CentralNotice.hooks.php
index 21c0efc..a8a6e33 100644
--- a/CentralNotice.hooks.php
+++ b/CentralNotice.hooks.php
@@ -217,7 +217,7 @@
// Insert DNS prefetch for banner loading
if ( $wgCentralHost && $wgCentralHost !== $wgServer ) {
- $out->addHeadItem( 'dns-prefetch', '<link rel="dns-prefetch"
href="' . htmlspecialchars( $wgCentralHost ) . '" />' );
+ $out->addHeadItem( 'cn-dns-prefetch', '<link rel="dns-prefetch"
href="' . htmlspecialchars( $wgCentralHost ) . '" />' );
}
// Insert the banner controller
// TODO Change this to startUp once it's determined that a rollback is
not
--
To view, visit https://gerrit.wikimedia.org/r/293040
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I2fb7f3b9f3763f2395cd3120eda5d7e2d2aaebe0
Gerrit-PatchSet: 2
Gerrit-Project: mediawiki/extensions/CentralNotice
Gerrit-Branch: master
Gerrit-Owner: Ori.livneh <o...@wikimedia.org>
Gerrit-Reviewer: AndyRussG <andrew.green...@gmail.com>
Gerrit-Reviewer: Awight <awi...@wikimedia.org>
Gerrit-Reviewer: Cdentinger <cdentin...@wikimedia.org>
Gerrit-Reviewer: Ejegg <eeggles...@wikimedia.org>
Gerrit-Reviewer: Krinkle <krinklem...@gmail.com>
Gerrit-Reviewer: Ssmith <ssm...@wikimedia.org>
Gerrit-Reviewer: XenoRyet <dkozlow...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
