Alexandros Kosiaris has submitted this change and it was merged.
Change subject: ferm: Remove EXTERNAL_NETWORKS
......................................................................
ferm: Remove EXTERNAL_NETWORKS
The only use of it has been removed from the tree in I74cb2ed6d9b and it
is quite obvious that is was never really useful. Remove it from the
ferm rules
Change-Id: I476dbb0c89a5627bebe01216e5e7cb6d4f23ef01
---
M modules/base/templates/firewall/defs.erb
1 file changed, 0 insertions(+), 2 deletions(-)
Approvals:
Alexandros Kosiaris: Looks good to me, approved
jenkins-bot: Verified
diff --git a/modules/base/templates/firewall/defs.erb
b/modules/base/templates/firewall/defs.erb
index a88c15e..2afa9e1 100644
--- a/modules/base/templates/firewall/defs.erb
+++ b/modules/base/templates/firewall/defs.erb
@@ -1,5 +1,4 @@
<%-
-external_networks = scope.lookupvar('network::constants::external_networks')
domain_networks = scope.lookupvar('network::constants::domain_networks')
all_networks = scope.lookupvar('network::constants::all_networks')
all_network_subnets =
scope.lookupvar('network::constants::all_network_subnets')
@@ -14,7 +13,6 @@
# $DOMAIN_NETWORKS is a set of all networks belonging to a domain.
# a domain is a realm currently, but the notion is more generic than that on
purpose
@def $DOMAIN_NETWORKS = (<%- domain_networks.each do |net| -%><%= net %> <%
end -%>);
-@def $EXTERNAL_NETWORKS = (<%- external_networks.each do |external_net| -%><%=
external_net %> <% end -%>);
@def $ALL_NETWORKS = (<%- all_networks.each do |net| -%><%= net %> <% end -%>);
# $PRODUCTION_NETWORKS is a set of all production networks
--
To view, visit https://gerrit.wikimedia.org/r/296379
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I476dbb0c89a5627bebe01216e5e7cb6d4f23ef01
Gerrit-PatchSet: 2
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Gehel <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
