Adrian Heine has uploaded a new change for review.
https://gerrit.wikimedia.org/r/297364
Change subject: Rename event afterchange to change
......................................................................
Rename event afterchange to change
Change-Id: I1361c579ade6375878444ee657a0bb0c385df55f
---
M view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
M view/resources/jquery/wikibase/jquery.wikibase.statementview.js
2 files changed, 5 insertions(+), 5 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase
refs/changes/64/297364/1
diff --git
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
index f58d818..9076b31 100644
---
a/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
+++
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.RankSelector.js
@@ -50,8 +50,8 @@
* Whether the widget is displayed in right-to-left context.
*/
/**
- * @event afterchange
- * Triggered after the snak type got changed.
+ * @event change
+ * Triggered when the snak type got changed.
* @param {jQuery.Event} event
*/
$.wikibase.statementview.RankSelector = util.inherit( PARENT, {
@@ -174,7 +174,7 @@
var response = PARENT.prototype._setOption.apply( this,
arguments );
if ( key === 'rank' ) {
this._setRank( value );
- this._trigger( 'afterchange' );
+ this._trigger( 'change' );
} else if ( key === 'disabled' ) {
this.draw();
}
@@ -235,7 +235,7 @@
this._setRank( rank );
- this._trigger( 'afterchange' );
+ this._trigger( 'change' );
},
/**
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
index 848c741..614534a 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.statementview.js
@@ -185,7 +185,7 @@
}, $rankSelector );
var self = this,
- changeEvent = ( this._rankSelector.widgetEventPrefix +
'afterchange' ).toLowerCase();
+ changeEvent = ( this._rankSelector.widgetEventPrefix +
'change' ).toLowerCase();
this.$rankSelector.on( changeEvent + '.' + this.widgetName,
function( event ) {
if ( self.value() ) {
--
To view, visit https://gerrit.wikimedia.org/r/297364
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I1361c579ade6375878444ee657a0bb0c385df55f
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Heine <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
