[MediaWiki-commits] [Gerrit] Remove ! and . and - from the list of allowed characters - change (mediawiki...UrlShortener)

[Prtksxna (Code Review)]

Prtksxna has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/297743

Change subject: Remove ! and . and - from the list of allowed characters
......................................................................

Remove ! and . and - from the list of allowed characters

Bug: T139515
Change-Id: Ic76e59711a64f128fb11ca7dc8886dabaaadc369
---
M README
M extension.json
M tests/phpunit/UrlShortenerUtilsTest.php
3 files changed, 3 insertions(+), 3 deletions(-)


  git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/UrlShortener 
refs/changes/43/297743/1

diff --git a/README b/README
index 1d00c67..d7dcb84 100644
--- a/README
+++ b/README
@@ -102,7 +102,7 @@
 destination.
 
 <source lang="php">
-$wgUrlShortenerIdSet = 
'023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$-_.!';
+$wgUrlShortenerIdSet = 
'023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$_';
 </source>
 
 === Read-only mode ===
diff --git a/extension.json b/extension.json
index 655e901..07b3108 100644
--- a/extension.json
+++ b/extension.json
@@ -101,7 +101,7 @@
                "UrlShortenerDBCluster": false,
                "UrlShortenerDBName": false,
                "UrlShortenerDomainsWhitelist": false,
-               "UrlShortenerIdSet": 
"023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$-_.!",
+               "UrlShortenerIdSet": 
"023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$_",
                "UrlShortenerServer": false,
                "UrlShortenerTemplate": false,
                "UrlShortenerAllowArbitraryPorts": false,
diff --git a/tests/phpunit/UrlShortenerUtilsTest.php 
b/tests/phpunit/UrlShortenerUtilsTest.php
index 6fd2453..91ff987 100644
--- a/tests/phpunit/UrlShortenerUtilsTest.php
+++ b/tests/phpunit/UrlShortenerUtilsTest.php
@@ -66,7 +66,7 @@
                // Set default
                $this->setMwGlobals(
                        'wgUrlShortenerIdSet',
-                       
'023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$-_.!'
+                       
'023456789ABCDEFGHJKLMNOPQRSTUVWXYZabcdefghijkmnopqrstuvwxyz$_'
                );
                for ( $i = 0; $i < 1000; $i++ ) {
                        $int = rand();

-- 
To view, visit https://gerrit.wikimedia.org/r/297743
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Ic76e59711a64f128fb11ca7dc8886dabaaadc369
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/UrlShortener
Gerrit-Branch: master
Gerrit-Owner: Prtksxna <psax...@wikimedia.org>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits