Ottomata has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298314
Change subject: Use $statistics::working_path variable in statistics::wmde
......................................................................
Use $statistics::working_path variable in statistics::wmde
stat1002 has a legacy issue between /a and /srv. $statistics::working_path
abstracts this problem away.
This also de-parameterizes, $user and $dir as we are very unlikely to ever
change them.
Change-Id: Iac92c6c619a3e0ac2a586c1c3d9f65d99fc3a342
---
M modules/statistics/manifests/wmde.pp
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/puppet
refs/changes/14/298314/1
diff --git a/modules/statistics/manifests/wmde.pp
b/modules/statistics/manifests/wmde.pp
index fa17817..1ad72d9 100644
--- a/modules/statistics/manifests/wmde.pp
+++ b/modules/statistics/manifests/wmde.pp
@@ -11,12 +11,12 @@
# - Dumps
#
# And send the data to statsd or graphite directly
-class statistics::wmde(
- $user = 'analytics-wmde',
- $dir = '/srv/analytics-wmde'
-) {
+class statistics::wmde {
Class['::statistics'] -> Class['::statistics::wmde']
+ $user = 'analytics-wmde'
+ $dir = "${::statistics::working_path}/analytics-wmde"
+
# Path in which all crons will log to.
$log_dir = "${dir}/log"
--
To view, visit https://gerrit.wikimedia.org/r/298314
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac92c6c619a3e0ac2a586c1c3d9f65d99fc3a342
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Ottomata <[email protected]>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
