Dzahn has submitted this change and it was merged.

Change subject: admin: add eventlogging-admins in webperf role
......................................................................


admin: add eventlogging-admins in webperf role

As the ticket says, it looks like this access existed
before in the past, until it was removed a couple months
ago, probably by accident in some refactoring, but it's not
clear yet where exactly.

Anyways, i suggest just adding the group (back) here because:

- nuria reports they had it before and need it
- ori confirms and supports it
- the admin class name matches what this host does "monitoring of EventLogging 
event streams"
- it's most likely a regression that happened by accident

PS3: After comments above, now adding eventlogging-admins into the existing 
webperf role

Bug:T139202
Change-Id: I14d7f21d71c77c33da6cf674eae69431fb205e19
---
M hieradata/role/common/webperf.yaml
1 file changed, 1 insertion(+), 0 deletions(-)

Approvals:
  jenkins-bot: Verified
  Dzahn: Looks good to me, approved



diff --git a/hieradata/role/common/webperf.yaml 
b/hieradata/role/common/webperf.yaml
index 8ece7e0..0aedb66 100644
--- a/hieradata/role/common/webperf.yaml
+++ b/hieradata/role/common/webperf.yaml
@@ -1,5 +1,6 @@
 admin::groups:
   - perf-roots
+  - eventlogging-admins
 debdeploy::grains:
   debdeploy-webperf:
     value: standard

-- 
To view, visit https://gerrit.wikimedia.org/r/298120
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: I14d7f21d71c77c33da6cf674eae69431fb205e19
Gerrit-PatchSet: 5
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Dzahn <[email protected]>
Gerrit-Reviewer: Alex Monk <[email protected]>
Gerrit-Reviewer: Alexandros Kosiaris <[email protected]>
Gerrit-Reviewer: Dzahn <[email protected]>
Gerrit-Reviewer: Elukey <[email protected]>
Gerrit-Reviewer: Faidon Liambotis <[email protected]>
Gerrit-Reviewer: Legoktm <[email protected]>
Gerrit-Reviewer: Madhuvishy <[email protected]>
Gerrit-Reviewer: Muehlenhoff <[email protected]>
Gerrit-Reviewer: Nuria <[email protected]>
Gerrit-Reviewer: Ori.livneh <[email protected]>
Gerrit-Reviewer: Ottomata <[email protected]>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to