Legoktm has uploaded a new change for review.
https://gerrit.wikimedia.org/r/298416
Change subject: Don't block logins if CentralAuthUser::queryAttached() fails
......................................................................
Don't block logins if CentralAuthUser::queryAttached() fails
Bug: T119736
Change-Id: I45212e41d164b2f1d5a354057650aa04edf30d4e
---
M wmf-config/CommonSettings.php
1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://gerrit.wikimedia.org:29418/operations/mediawiki-config
refs/changes/16/298416/1
diff --git a/wmf-config/CommonSettings.php b/wmf-config/CommonSettings.php
index cc3dc2e..89dc4af 100644
--- a/wmf-config/CommonSettings.php
+++ b/wmf-config/CommonSettings.php
@@ -410,7 +410,13 @@
}
// Result should be cached by getLocalGroups() above
- $attachInfo = $central->queryAttached();
+ try {
+ $attachInfo = $central->queryAttached();
+ } catch ( Exception $e ) {
+ // Don't block login if we can't query attached
(T119736)
+ MWExceptionHandler::logException( $e );
+ return true;
+ }
$enforceWikiGroups = [
'centralnoticeadmin' => [ 'metawiki', 'testwiki' ],
'templateeditor' => [ 'fawiki', 'rowiki' ],
--
To view, visit https://gerrit.wikimedia.org/r/298416
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I45212e41d164b2f1d5a354057650aa04edf30d4e
Gerrit-PatchSet: 1
Gerrit-Project: operations/mediawiki-config
Gerrit-Branch: master
Gerrit-Owner: Legoktm <legoktm.wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
