jenkins-bot has submitted this change and it was merged.
Change subject: Fix stupid logic errors in starting/stopping
......................................................................
Fix stupid logic errors in starting/stopping
This is why all starts/stops have been taking about 30s
Change-Id: I4879f25794f554e6a407b7888bd172ad13fd4fdc
---
M scripts/webservice
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
BryanDavis: Looks good to me, approved
jenkins-bot: Verified
diff --git a/scripts/webservice b/scripts/webservice
index 9c2bc6d..a0e6274 100755
--- a/scripts/webservice
+++ b/scripts/webservice
@@ -31,12 +31,12 @@
except WebService.InvalidWebServiceException as e:
raise SystemExit(e.message)
# FIXME: Treat pending state differently.
- wait_for(lambda: job.get_state() != Backend.STATE_RUNNING, message)
+ wait_for(lambda: job.get_state() == Backend.STATE_RUNNING, message)
def stop(job, message):
job.request_stop()
- wait_for(lambda: not job.get_state() == Backend.STATE_STOPPED, message)
+ wait_for(lambda: job.get_state() == Backend.STATE_STOPPED, message)
def update_manifest(job, action):
--
To view, visit https://gerrit.wikimedia.org/r/298454
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I4879f25794f554e6a407b7888bd172ad13fd4fdc
Gerrit-PatchSet: 2
Gerrit-Project: operations/software/tools-webservice
Gerrit-Branch: master
Gerrit-Owner: Yuvipanda <[email protected]>
Gerrit-Reviewer: BryanDavis <[email protected]>
Gerrit-Reviewer: Merlijn van Deen <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
