jenkins-bot has submitted this change and it was merged. Change subject: rename vars in SkinTemplate::outputPage() ......................................................................
rename vars in SkinTemplate::outputPage() The $tmp, $l names are not very meaningfull. This patch rename some variables and avoid calling methods by adding some more variables. Overall this cleanup the code to be more readable. Change-Id: I4d2018c6cf3f651647bcb9e235b8322943bd5728 --- M includes/SkinTemplate.php 1 file changed, 15 insertions(+), 12 deletions(-) Approvals: Hashar: Looks good to me, approved jenkins-bot: Verified -- To view, visit https://gerrit.wikimedia.org/r/16610 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: merged Gerrit-Change-Id: I4d2018c6cf3f651647bcb9e235b8322943bd5728 Gerrit-PatchSet: 9 Gerrit-Project: mediawiki/core Gerrit-Branch: master Gerrit-Owner: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Amire80 <amir.ahar...@mail.huji.ac.il> Gerrit-Reviewer: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Eranroz <eranro...@gmail.com> Gerrit-Reviewer: Hashar <has...@free.fr> Gerrit-Reviewer: Nikerabbit <niklas.laxst...@gmail.com> Gerrit-Reviewer: SPQRobin <robinp.1...@gmail.com> Gerrit-Reviewer: jenkins-bot _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
