[MediaWiki-commits] [Gerrit] Add more logging - change (wikidata...rdf)

[jenkins-bot (Code Review)]

jenkins-bot has submitted this change and it was merged.

Change subject: Add more logging
......................................................................


Add more logging

Change-Id: Iddd557e2141d63a9d87372a7573e38966d75907f
---
M tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
M 
tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
2 files changed, 18 insertions(+), 2 deletions(-)

Approvals:
  Smalyshev: Looks good to me, approved
  jenkins-bot: Verified



diff --git a/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java 
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
index d65fa01..e7cc07b 100644
--- a/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
+++ b/tools/src/main/java/org/wikidata/query/rdf/tool/change/Change.java
@@ -8,6 +8,7 @@
 
 import org.openrdf.model.Statement;
 import org.wikidata.query.rdf.tool.exception.RetryableException;
+import org.wikidata.query.rdf.tool.wikibase.WikibaseRepository;
 
 import com.google.common.collect.ImmutableList;
 
@@ -101,7 +102,8 @@
             b.append('@').append(revision);
         }
         if (timestamp != null) {
-            b.append("@").append(timestamp);
+            
b.append("@").append(WikibaseRepository.outputDateFormat().format(timestamp));
+            b.append("|").append(rcid);
         }
         return b.toString();
     }
diff --git 
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
 
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
index e4bf556..7b79e87 100644
--- 
a/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
+++ 
b/tools/src/main/java/org/wikidata/query/rdf/tool/change/RecentChangesPoller.java
@@ -87,6 +87,12 @@
         public Date leftOffDate() {
             return leftOffDate;
         }
+
+        @Override
+        public String leftOffHuman() {
+            return leftOffDate.toString() + " (next: " + 
nextContinue.get("rccontinue").toString()
+                    + ")";
+        }
     }
 
     /**
@@ -108,7 +114,7 @@
                 JSONObject rc = (JSONObject) rco;
                 long namespace = (long) rc.get("ns");
                 if (!wikibase.isEntityNamespace(namespace)) {
-                    log.debug("Skipping change in irrelevant namespace:  {}", 
rc);
+                    log.info("Skipping change in irrelevant namespace:  {}", 
rc);
                     continue;
                 }
                 Date timestamp = df.parse(rc.get("timestamp").toString());
@@ -142,6 +148,14 @@
                 }
             }
 
+            if (changes.size() != 0) {
+                log.info("Got {} changes, from {} to {}", changes.size(),
+                        changes.get(0).toString(),
+                        changes.get(changes.size() - 1).toString());
+            } else {
+                log.info("Got no real changes");
+            }
+
             // Show the user the polled time - one second because we can't
             // be sure we got the whole second
             String upTo = inputDateFormat().format(new Date(nextStartTime - 
1000));

-- 
To view, visit https://gerrit.wikimedia.org/r/299274
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: merged
Gerrit-Change-Id: Iddd557e2141d63a9d87372a7573e38966d75907f
Gerrit-PatchSet: 1
Gerrit-Project: wikidata/query/rdf
Gerrit-Branch: master
Gerrit-Owner: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: Smalyshev <smalys...@wikimedia.org>
Gerrit-Reviewer: jenkins-bot <>

_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits