Seb35 has uploaded a new change for review.
https://gerrit.wikimedia.org/r/299390
Change subject: Micro-optimisation: preg_replace to str_replace
......................................................................
Micro-optimisation: preg_replace to str_replace
---
M src/MediaWikiFarm.php
1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/MediaWikiFarm
refs/changes/90/299390/1
diff --git a/src/MediaWikiFarm.php b/src/MediaWikiFarm.php
index 873ab50..2efd5cc 100644
--- a/src/MediaWikiFarm.php
+++ b/src/MediaWikiFarm.php
@@ -576,7 +576,7 @@
foreach( $values as $wiki =>
$val ) {
if( $wiki == 'default'
&& $defaultKey ) $wgConf->settings[$setting][$defaultKey] = $val;
- else
$wgConf->settings[$setting][preg_replace( '/\*/', $wiki, $classicKey )] = $val;
+ else
$wgConf->settings[$setting][str_replace( '*', $wiki, $classicKey )] = $val;
}
}
}
@@ -823,7 +823,7 @@
$rvalues = array();
foreach( $this->variables as $key => $val ) {
- $rkeys[] = '/\$' . preg_quote( $key, '/' ) .
'/';
+ $rkeys[] = '$' . $key;
$rvalues[] = $val;
}
}
@@ -832,7 +832,7 @@
return '';
elseif( is_string( $value ) )
- $value = preg_replace( $rkeys, $rvalues, $value );
+ $value = str_replace( $rkeys, $rvalues, $value );
elseif( !is_array( $value ) ) {
@@ -843,7 +843,7 @@
foreach( $value as &$subvalue ) {
foreach( $subvalue as &$subsubvalue )
- $subsubvalue = preg_replace( $rkeys,
$rvalues, $subsubvalue );
+ $subsubvalue = str_replace( $rkeys,
$rvalues, $subsubvalue );
}
}
--
To view, visit https://gerrit.wikimedia.org/r/299390
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I0ebebbfd542571d56d43633a9ed4bee2170ba438
Gerrit-PatchSet: 1
Gerrit-Project: mediawiki/extensions/MediaWikiFarm
Gerrit-Branch: master
Gerrit-Owner: Seb35 <seb35wikipe...@gmail.com>
_______________________________________________
MediaWiki-commits mailing list
MediaWiki-commits@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
