Yuvipanda has uploaded a new change for review.

  https://gerrit.wikimedia.org/r/299529

Change subject: tools: Timeout on toolschecker etcd instances
......................................................................

tools: Timeout on toolschecker etcd instances

If the instance is stuck the default timeout is too large,
and will cause other checks to fail.

Change-Id: I5827a9e0c1d879c72423d3120786a2fd16869ca6
---
M modules/toollabs/files/toolschecker.py
1 file changed, 1 insertion(+), 1 deletion(-)


  git pull ssh://gerrit.wikimedia.org:29418/operations/puppet 
refs/changes/29/299529/1

diff --git a/modules/toollabs/files/toolschecker.py 
b/modules/toollabs/files/toolschecker.py
index f24e094..59bdcb9 100644
--- a/modules/toollabs/files/toolschecker.py
+++ b/modules/toollabs/files/toolschecker.py
@@ -323,7 +323,7 @@
     # Don't do https verification because we are using puppet certificate for 
validating
     # it and tools-checker infrastructure runs on the labs puppetmaster 
because we have a
     # check for the labs puppetmaster in here...
-    request = requests.get('https://{host}:2379/health'.format(host=host), 
verify=False)
+    request = requests.get('https://{host}:2379/health'.format(host=host), 
timeout=3, verify=False)
     if request.status_code == 200:
         return request.json()['health'] == 'true'
     return False

-- 
To view, visit https://gerrit.wikimedia.org/r/299529
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: I5827a9e0c1d879c72423d3120786a2fd16869ca6
Gerrit-PatchSet: 1
Gerrit-Project: operations/puppet
Gerrit-Branch: production
Gerrit-Owner: Yuvipanda <[email protected]>

_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits

Reply via email to