jenkins-bot has submitted this change and it was merged.
Change subject: Use listview::value in referenceview
......................................................................
Use listview::value in referenceview
Change-Id: I13e48847fcc5cdb46ca668247516774e08e73393
---
M view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
1 file changed, 1 insertion(+), 10 deletions(-)
Approvals:
Thiemo Mättig (WMDE): Looks good to me, approved
jenkins-bot: Verified
diff --git a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
index 3ba79b3..332c904 100644
--- a/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
+++ b/view/resources/jquery/wikibase/jquery.wikibase.referenceview.js
@@ -254,16 +254,7 @@
*/
_stopEditingReferenceSnaks: function() {
var listview = this.$listview.data( 'listview' );
-
- listview.items().each( function() {
- listview.removeItem( $( this ) );
- } );
-
- if ( this.options.value ) {
- $.each(
this.options.value.getSnaks().getGroupedSnakLists(), function() {
- listview.addItem( this );
- } );
- }
+ listview.value( this.options.value ?
this.options.value.getSnaks().getGroupedSnakLists() : [] );
},
/**
--
To view, visit https://gerrit.wikimedia.org/r/297358
To unsubscribe, visit https://gerrit.wikimedia.org/r/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I13e48847fcc5cdb46ca668247516774e08e73393
Gerrit-PatchSet: 3
Gerrit-Project: mediawiki/extensions/Wikibase
Gerrit-Branch: master
Gerrit-Owner: Adrian Heine <[email protected]>
Gerrit-Reviewer: Adrian Heine <[email protected]>
Gerrit-Reviewer: Thiemo Mättig (WMDE) <[email protected]>
Gerrit-Reviewer: jenkins-bot <>
_______________________________________________
MediaWiki-commits mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits
