Aude has uploaded a new change for review. https://gerrit.wikimedia.org/r/300749
Change subject: Prevent undeleting entities from ending with an exception ...................................................................... Prevent undeleting entities from ending with an exception Bug: T140533 Change-Id: I4b256879e212dce01efd1def662cab8dcb97b4e7 (cherry picked from commit a5b635a9603b4649a2e4e8f66d3f6e54c8a6c189) --- M repo/Wikibase.hooks.php 1 file changed, 1 insertion(+), 1 deletion(-) git pull ssh://gerrit.wikimedia.org:29418/mediawiki/extensions/Wikibase refs/changes/49/300749/1 diff --git a/repo/Wikibase.hooks.php b/repo/Wikibase.hooks.php index 576be14..a9a9690 100644 --- a/repo/Wikibase.hooks.php +++ b/repo/Wikibase.hooks.php @@ -458,7 +458,7 @@ : $skinTemplate->getRevisionId(); $rev = Revision::newFromId( $revid ); - if ( $rev->isDeleted( Revision::DELETED_TEXT ) ) { + if ( !$rev || $rev->isDeleted( Revision::DELETED_TEXT ) ) { return; } -- To view, visit https://gerrit.wikimedia.org/r/300749 To unsubscribe, visit https://gerrit.wikimedia.org/r/settings Gerrit-MessageType: newchange Gerrit-Change-Id: I4b256879e212dce01efd1def662cab8dcb97b4e7 Gerrit-PatchSet: 1 Gerrit-Project: mediawiki/extensions/Wikibase Gerrit-Branch: wmf/1.28.0-wmf.9 Gerrit-Owner: Aude <aude.w...@gmail.com> Gerrit-Reviewer: Matěj Suchánek <matejsuchane...@gmail.com> _______________________________________________ MediaWiki-commits mailing list MediaWiki-commits@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/mediawiki-commits